[PR #442] [MERGED] chore: clear lint backlog in batches and enforce quality gates #531

New issue

Closed

opened 2026-02-26 22:31:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/442
Author: @rudrankriyam
Created: 2/7/2026
Status: ✅ Merged
Merged: 2/7/2026
Merged by: @rudrankriyam

Base: main ← Head: chore/lint-backlog-batches

📝 Commits (2)

8e4394a chore(lint): clear backlog and prune unused wrappers
6fdb5a6 ci: enforce format/lint gates and add pre-commit hook

📊 Changes

33 files changed (+146 additions, -293 deletions)

View changed files

➕ .githooks/pre-commit (+21 -0)
📝 .github/workflows/main-branch.yml (+14 -0)
📝 .github/workflows/pr-checks.yml (+14 -0)
📝 AGENTS.md (+8 -0)
📝 Makefile (+9 -0)
📝 cmd/shared.go (+0 -55)
📝 internal/asc/client_test.go (+4 -1)
📝 internal/asc/notary.go (+1 -4)
📝 internal/asc/notary_test.go (+23 -9)
📝 internal/asc/output_game_center.go (+0 -18)
📝 internal/auth/doctor_test.go (+1 -1)
📝 internal/auth/keychain.go (+0 -4)
📝 internal/cli/app_events/shared_wrappers.go (+0 -8)
📝 internal/cli/buildbundles/shared_wrappers.go (+0 -4)
📝 internal/cli/bundleids/shared_wrappers.go (+0 -12)
📝 internal/cli/cmdtest/debug_test.go (+3 -1)
📝 internal/cli/encryption/shared_wrappers.go (+0 -4)
📝 internal/cli/eula/shared_wrappers.go (+0 -8)
📝 internal/cli/gamecenter/game_center_matchmaking.go (+0 -10)
📝 internal/cli/gamecenter/shared_wrappers.go (+0 -4)

...and 13 more files

📄 Description

Summary

clear the accumulated lint backlog (unused wrappers, errcheck/staticcheck/ineffassign issues)
remove dead shared-wrapper helpers and stale helper functions introduced by refactors
add guardrails so this class of issue is blocked before merge

Root Cause

many package-level shared_wrappers helpers were copied/generated for command groups and later became unused after command refactors
PR/Main CI workflows ran tests/builds but did not run formatting or lint gates
no local pre-commit enforcement existed, so unused helpers could accumulate until a dedicated cleanup pass

What changed (batched)

Lint cleanup batch
- fix unchecked writes/encodes in tests
- address staticcheck/gosimple/ineffassign findings
- remove unused wrappers/helpers across affected command packages
Prevention batch
- add format + lint gates to PR and main workflows
- add local .githooks/pre-commit running format/lint/short-tests
- add make install-hooks target
- update AGENTS.md with PR guardrails

Validation

make format
make lint
make test

Notes

PR #436 was merged first and its post-merge main workflow run succeeded (no regressions from that PR).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/442 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/7/2026 **Status:** ✅ Merged **Merged:** 2/7/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `chore/lint-backlog-batches` --- ### 📝 Commits (2) - [`8e4394a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8e4394a1041e3d3135457d6674368be0e3b1c266) chore(lint): clear backlog and prune unused wrappers - [`6fdb5a6`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6fdb5a6a0091c8bb2ea33a34757645dad7211f18) ci: enforce format/lint gates and add pre-commit hook ### 📊 Changes **33 files changed** (+146 additions, -293 deletions) <details> <summary>View changed files</summary> ➕ `.githooks/pre-commit` (+21 -0) 📝 `.github/workflows/main-branch.yml` (+14 -0) 📝 `.github/workflows/pr-checks.yml` (+14 -0) 📝 `AGENTS.md` (+8 -0) 📝 `Makefile` (+9 -0) 📝 `cmd/shared.go` (+0 -55) 📝 `internal/asc/client_test.go` (+4 -1) 📝 `internal/asc/notary.go` (+1 -4) 📝 `internal/asc/notary_test.go` (+23 -9) 📝 `internal/asc/output_game_center.go` (+0 -18) 📝 `internal/auth/doctor_test.go` (+1 -1) 📝 `internal/auth/keychain.go` (+0 -4) 📝 `internal/cli/app_events/shared_wrappers.go` (+0 -8) 📝 `internal/cli/buildbundles/shared_wrappers.go` (+0 -4) 📝 `internal/cli/bundleids/shared_wrappers.go` (+0 -12) 📝 `internal/cli/cmdtest/debug_test.go` (+3 -1) 📝 `internal/cli/encryption/shared_wrappers.go` (+0 -4) 📝 `internal/cli/eula/shared_wrappers.go` (+0 -8) 📝 `internal/cli/gamecenter/game_center_matchmaking.go` (+0 -10) 📝 `internal/cli/gamecenter/shared_wrappers.go` (+0 -4) _...and 13 more files_ </details> ### 📄 Description ## Summary - clear the accumulated lint backlog (unused wrappers, errcheck/staticcheck/ineffassign issues) - remove dead shared-wrapper helpers and stale helper functions introduced by refactors - add guardrails so this class of issue is blocked before merge ## Root Cause - many package-level `shared_wrappers` helpers were copied/generated for command groups and later became unused after command refactors - PR/Main CI workflows ran tests/builds but did not run formatting or lint gates - no local pre-commit enforcement existed, so unused helpers could accumulate until a dedicated cleanup pass ## What changed (batched) 1. **Lint cleanup batch** - fix unchecked writes/encodes in tests - address staticcheck/gosimple/ineffassign findings - remove unused wrappers/helpers across affected command packages 2. **Prevention batch** - add `format` + `lint` gates to PR and main workflows - add local `.githooks/pre-commit` running format/lint/short-tests - add `make install-hooks` target - update `AGENTS.md` with PR guardrails ## Validation - `make format` - `make lint` - `make test` ## Notes - PR #436 was merged first and its post-merge `main` workflow run succeeded (no regressions from that PR). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>