[PR #432] [MERGED] Macos notarization feature #523

New issue

Closed

opened 2026-02-26 22:31:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/432
Author: @rudrankriyam
Created: 2/6/2026
Status: ✅ Merged
Merged: 2/6/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/macos-notarization-feature-953d

📝 Commits (10+)

7156b51 Add Notary API client: types, JWT, HTTP methods, S3 upload, SHA256
5d7d703 Add notarization CLI commands and register in command tree
9448050 Add CLI validation tests for notarization commands
d20aea0 Apply gofumpt formatting
6177893 Add notarization usage examples to README
4ee5b2d Improve notary tests: use httptest through actual client methods
1bcbd6a Exit non-zero on failed notarization; add empty file test
8008ba0 Add table and markdown output for notary response types
164fc1d Add table/markdown output tests for notary response types
6fcd4e5 Fix unknown status causing wait polling to exit early

📊 Changes

19 files changed (+2702 additions, -44 deletions)

View changed files

📝 README.md (+31 -0)
📝 internal/asc/client_core.go (+5 -4)
📝 internal/asc/client_pagination_test.go (+0 -2)
📝 internal/asc/client_types.go (+20 -16)
📝 internal/asc/iap_queries.go (+10 -8)
📝 internal/asc/iap_resources.go (+16 -8)
➕ internal/asc/notary.go (+829 -0)
➕ internal/asc/notary_test.go (+783 -0)
📝 internal/asc/output_core.go (+12 -0)
➕ internal/asc/output_notary.go (+79 -0)
➕ internal/asc/output_notary_test.go (+197 -0)
📝 internal/cli/cmdtest/builds_parity_test.go (+2 -1)
➕ internal/cli/cmdtest/notarization_test.go (+259 -0)
➕ internal/cli/notarization/commands.go (+8 -0)
➕ internal/cli/notarization/notarization.go (+412 -0)
➕ internal/cli/notarization/shared_wrappers.go (+30 -0)
📝 internal/cli/publish/group_resolver_test.go (+3 -3)
📝 internal/cli/registry/registry.go (+2 -0)
📝 internal/cli/shared/shared.go (+4 -2)

📄 Description

Implement the macOS Notarization feature by adding an asc notarization command group to manage notarization submissions via the Apple Notary API v2.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/432 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/6/2026 **Status:** ✅ Merged **Merged:** 2/6/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/macos-notarization-feature-953d` --- ### 📝 Commits (10+) - [`7156b51`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7156b51032e222358743dd60e5591119ade52d9a) Add Notary API client: types, JWT, HTTP methods, S3 upload, SHA256 - [`5d7d703`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/5d7d7034a37be0f357aa6f686d966030963c7a07) Add notarization CLI commands and register in command tree - [`9448050`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/94480504e3d9d86c233c7c4c509445d579666aa8) Add CLI validation tests for notarization commands - [`d20aea0`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d20aea05c0adf53110a8091b3f2d1482c8612487) Apply gofumpt formatting - [`6177893`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6177893d60ffb0f5004c3fd9cf0537897a33b760) Add notarization usage examples to README - [`4ee5b2d`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4ee5b2dad196c78aa567592050f231149e3b6450) Improve notary tests: use httptest through actual client methods - [`1bcbd6a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/1bcbd6a0645ad62be6a5a7e48a7a8fc669048990) Exit non-zero on failed notarization; add empty file test - [`8008ba0`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8008ba0c79a692e05b0eba2878112cdd30e50a64) Add table and markdown output for notary response types - [`164fc1d`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/164fc1de611e228e288ef437f25f183bd5bdcada) Add table/markdown output tests for notary response types - [`6fcd4e5`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6fcd4e5cdde5028f002d815bc51aaecca276dd1b) Fix unknown status causing wait polling to exit early ### 📊 Changes **19 files changed** (+2702 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+31 -0) 📝 `internal/asc/client_core.go` (+5 -4) 📝 `internal/asc/client_pagination_test.go` (+0 -2) 📝 `internal/asc/client_types.go` (+20 -16) 📝 `internal/asc/iap_queries.go` (+10 -8) 📝 `internal/asc/iap_resources.go` (+16 -8) ➕ `internal/asc/notary.go` (+829 -0) ➕ `internal/asc/notary_test.go` (+783 -0) 📝 `internal/asc/output_core.go` (+12 -0) ➕ `internal/asc/output_notary.go` (+79 -0) ➕ `internal/asc/output_notary_test.go` (+197 -0) 📝 `internal/cli/cmdtest/builds_parity_test.go` (+2 -1) ➕ `internal/cli/cmdtest/notarization_test.go` (+259 -0) ➕ `internal/cli/notarization/commands.go` (+8 -0) ➕ `internal/cli/notarization/notarization.go` (+412 -0) ➕ `internal/cli/notarization/shared_wrappers.go` (+30 -0) 📝 `internal/cli/publish/group_resolver_test.go` (+3 -3) 📝 `internal/cli/registry/registry.go` (+2 -0) 📝 `internal/cli/shared/shared.go` (+4 -2) </details> ### 📄 Description Implement the macOS Notarization feature by adding an `asc notarization` command group to manage notarization submissions via the Apple Notary API v2. --- <p><a href="https://cursor.com/background-agent?bcId=bc-7314b8d6-641c-4e02-9ab2-5b9810a796b1"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-7314b8d6-641c-4e02-9ab2-5b9810a796b1"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>