[PR #386] [MERGED] chore: add dev tools target + safer format/lint #487

New issue

Closed

opened 2026-02-26 22:31:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/386
Author: @mitre88
Created: 2/1/2026
Status: ✅ Merged
Merged: 2/1/2026
Merged by: @rudrankriyam

Base: main ← Head: chore/make-format-fallback

📝 Commits (2)

ae03f77 chore: add dev tools target and safer lint/format
2b94fc5 chore: require gofumpt for format

📊 Changes

3 files changed (+35 additions, -4 deletions)

View changed files

📝 CONTRIBUTING.md (+2 -1)
📝 Makefile (+21 -3)
📝 README.md (+12 -0)

📄 Description

What

Add make tools to install gofumpt + golangci-lint.
Make make format and make lint gracefully fall back (with helpful install hints) when those tools aren’t present.
Add a short How to test in <10 minutes section to the README.

Notes

I couldn’t run make/go checks in the Clawdbot sandbox because make and the Go toolchain are not available and outbound installs are blocked. Please run the quick test steps locally/CI.

How to test (<10 min)

make tools   # optional
make format
make lint
make test
make build
./asc --help

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/386 **Author:** [@mitre88](https://github.com/mitre88) **Created:** 2/1/2026 **Status:** ✅ Merged **Merged:** 2/1/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `chore/make-format-fallback` --- ### 📝 Commits (2) - [`ae03f77`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/ae03f77d6013d05021ce5690321f89983f8805ef) chore: add dev tools target and safer lint/format - [`2b94fc5`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/2b94fc5400b49701d63de109d583628faa610faa) chore: require gofumpt for format ### 📊 Changes **3 files changed** (+35 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `CONTRIBUTING.md` (+2 -1) 📝 `Makefile` (+21 -3) 📝 `README.md` (+12 -0) </details> ### 📄 Description ### What - Add `make tools` to install `gofumpt` + `golangci-lint`. - Make `make format` and `make lint` gracefully fall back (with helpful install hints) when those tools aren’t present. - Add a short **How to test in <10 minutes** section to the README. ### Notes I couldn’t run `make`/`go` checks in the Clawdbot sandbox because `make` and the Go toolchain are not available and outbound installs are blocked. Please run the quick test steps locally/CI. ### How to test (<10 min) ```bash make tools # optional make format make lint make test make build ./asc --help ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>