[PR #356] [MERGED] Activity version nil handling #467

New issue

Closed

opened 2026-02-26 22:31:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/356
Author: @cursor[bot]
Created: 1/30/2026
Status: ✅ Merged
Merged: 1/30/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/activity-version-nil-handling-bd0a

📝 Commits (1)

b18ec18 Fix nil handling for activity version update

📊 Changes

1 file changed (+10 additions, -5 deletions)

View changed files

📝 internal/asc/client_game_center_activities.go (+10 -5)

📄 Description

Conditionally create Attributes in UpdateGameCenterActivityVersion to align nil handling with other update functions.

This change prevents sending an empty {"attributes": {}} object when fallbackURL is nil, ensuring the API omits the field entirely as expected, which avoids potential backend misinterpretations.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/356 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/30/2026 **Status:** ✅ Merged **Merged:** 1/30/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/activity-version-nil-handling-bd0a` --- ### 📝 Commits (1) - [`b18ec18`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b18ec18bbce2b92f30df5de2594d7f646397b060) Fix nil handling for activity version update ### 📊 Changes **1 file changed** (+10 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_game_center_activities.go` (+10 -5) </details> ### 📄 Description Conditionally create `Attributes` in `UpdateGameCenterActivityVersion` to align nil handling with other update functions. This change prevents sending an empty `{"attributes": {}}` object when `fallbackURL` is nil, ensuring the API omits the field entirely as expected, which avoids potential backend misinterpretations. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>