[PR #353] [MERGED] Game Center parity: challenges, activities, groups, matchmaking #466

New issue

Closed

opened 2026-02-26 22:31:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/353
Author: @rudrankriyam
Created: 1/30/2026
Status: ✅ Merged
Merged: 1/30/2026
Merged by: @rudrankriyam

Base: main ← Head: feat/game-center-parity

📝 Commits (4)

e18cd32 Add Game Center challenges, activities, groups, and matchmaking support.
b2d8eec Fix group-based challenge/activity creation.
cbd0f88 Add v2 Game Center achievements and leaderboards.
4044d1a Consolidate Game Center v2 client/types.

📊 Changes

35 files changed (+15341 additions, -33 deletions)

View changed files

📝 internal/asc/client_game_center.go (+210 -0)
➕ internal/asc/client_game_center_activities.go (+684 -0)
➕ internal/asc/client_game_center_activities_test.go (+826 -0)
➕ internal/asc/client_game_center_challenges.go (+590 -0)
➕ internal/asc/client_game_center_challenges_test.go (+732 -0)
➕ internal/asc/client_game_center_groups.go (+209 -0)
➕ internal/asc/client_game_center_groups_test.go (+287 -0)
➕ internal/asc/client_game_center_matchmaking.go (+729 -0)
➕ internal/asc/client_game_center_matchmaking_test.go (+763 -0)
📝 internal/asc/client_helpers.go (+8 -0)
📝 internal/asc/client_http_gamecenter_test.go (+268 -0)
📝 internal/asc/client_pagination.go (+50 -0)
📝 internal/asc/client_types.go (+18 -0)
📝 internal/asc/game_center.go (+16 -0)
📝 internal/asc/game_center_achievements.go (+18 -0)
➕ internal/asc/game_center_activities.go (+421 -0)
➕ internal/asc/game_center_challenges.go (+396 -0)
➕ internal/asc/game_center_groups.go (+96 -0)
📝 internal/asc/game_center_leaderboards.go (+18 -0)
➕ internal/asc/game_center_matchmaking.go (+554 -0)

...and 15 more files

📄 Description

Summary

add Game Center challenges, activities, groups, and matchmaking clients/types plus CLI commands (CRUD, relationships, localizations, images, releases, metrics)
add output formatting, pagination support, and cmdtests/client HTTP tests for new endpoints
fix matchmaking metrics parsing to handle array dataPoints and numeric granularity responses

Test plan

go test ./internal/asc -run GameCenter
go test ./internal/cli/cmdtest -run GameCenter
Manual smoke tests (live ASC): create/update/delete challenges, activities, groups, matchmaking; metrics queue-sizes + rule-errors
Note: group relationship set endpoints returned API error on a newly created group; investigation to follow

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/353 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/30/2026 **Status:** ✅ Merged **Merged:** 1/30/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feat/game-center-parity` --- ### 📝 Commits (4) - [`e18cd32`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e18cd328c2225e5f2bf579810780d3b8598e2b58) Add Game Center challenges, activities, groups, and matchmaking support. - [`b2d8eec`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b2d8eec9e48e54fabee58b28007dd02438ce486a) Fix group-based challenge/activity creation. - [`cbd0f88`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/cbd0f88c827e8fa58cf14bf4bee9809710e20c86) Add v2 Game Center achievements and leaderboards. - [`4044d1a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4044d1a802c3d44d7e0a703e78eac7e00641549c) Consolidate Game Center v2 client/types. ### 📊 Changes **35 files changed** (+15341 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_game_center.go` (+210 -0) ➕ `internal/asc/client_game_center_activities.go` (+684 -0) ➕ `internal/asc/client_game_center_activities_test.go` (+826 -0) ➕ `internal/asc/client_game_center_challenges.go` (+590 -0) ➕ `internal/asc/client_game_center_challenges_test.go` (+732 -0) ➕ `internal/asc/client_game_center_groups.go` (+209 -0) ➕ `internal/asc/client_game_center_groups_test.go` (+287 -0) ➕ `internal/asc/client_game_center_matchmaking.go` (+729 -0) ➕ `internal/asc/client_game_center_matchmaking_test.go` (+763 -0) 📝 `internal/asc/client_helpers.go` (+8 -0) 📝 `internal/asc/client_http_gamecenter_test.go` (+268 -0) 📝 `internal/asc/client_pagination.go` (+50 -0) 📝 `internal/asc/client_types.go` (+18 -0) 📝 `internal/asc/game_center.go` (+16 -0) 📝 `internal/asc/game_center_achievements.go` (+18 -0) ➕ `internal/asc/game_center_activities.go` (+421 -0) ➕ `internal/asc/game_center_challenges.go` (+396 -0) ➕ `internal/asc/game_center_groups.go` (+96 -0) 📝 `internal/asc/game_center_leaderboards.go` (+18 -0) ➕ `internal/asc/game_center_matchmaking.go` (+554 -0) _...and 15 more files_ </details> ### 📄 Description ## Summary - add Game Center challenges, activities, groups, and matchmaking clients/types plus CLI commands (CRUD, relationships, localizations, images, releases, metrics) - add output formatting, pagination support, and cmdtests/client HTTP tests for new endpoints - fix matchmaking metrics parsing to handle array dataPoints and numeric granularity responses ## Test plan - `go test ./internal/asc -run GameCenter` - `go test ./internal/cli/cmdtest -run GameCenter` - Manual smoke tests (live ASC): create/update/delete challenges, activities, groups, matchmaking; metrics queue-sizes + rule-errors - Note: group relationship set endpoints returned API error on a newly created group; investigation to follow --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>