[PR #351] [MERGED] IAP command output handling #462

New issue

Closed

opened 2026-02-26 22:31:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/351
Author: @cursor[bot]
Created: 1/30/2026
Status: ✅ Merged
Merged: 1/30/2026
Merged by: @rudrankriyam

Base: cursor/in-app-purchases-sub-resources-3ff8 ← Head: cursor/iap-command-output-handling-157f

📝 Commits (1)

532587f Fix IAP update uploads and localization output

📊 Changes

6 files changed (+171 additions, -8 deletions)

View changed files

📝 internal/asc/iap_output_test.go (+48 -0)
📝 internal/asc/output_core.go (+4 -0)
📝 internal/cli/iap/helpers.go (+28 -0)
➕ internal/cli/iap/helpers_test.go (+27 -0)
📝 internal/cli/iap/images.go (+32 -4)
📝 internal/cli/iap/review_screenshots.go (+32 -4)

📄 Description

Fixes IAP image/screenshot re-upload logic and adds output handlers for single IAP localization responses.

The IAP image and review screenshot update commands previously failed for existing assets because GET requests do not provide upload operations. The fix now creates a new upload reservation, uploads the file, commits it, and then deletes the old asset. Additionally, *InAppPurchaseLocalizationResponse was missing from markdown and table output handlers, causing "unsupported type" errors for create/update operations.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/351 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/30/2026 **Status:** ✅ Merged **Merged:** 1/30/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `cursor/in-app-purchases-sub-resources-3ff8` ← **Head:** `cursor/iap-command-output-handling-157f` --- ### 📝 Commits (1) - [`532587f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/532587f0895eb619aa8d4e48924b19914bfbd9d8) Fix IAP update uploads and localization output ### 📊 Changes **6 files changed** (+171 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/iap_output_test.go` (+48 -0) 📝 `internal/asc/output_core.go` (+4 -0) 📝 `internal/cli/iap/helpers.go` (+28 -0) ➕ `internal/cli/iap/helpers_test.go` (+27 -0) 📝 `internal/cli/iap/images.go` (+32 -4) 📝 `internal/cli/iap/review_screenshots.go` (+32 -4) </details> ### 📄 Description Fixes IAP image/screenshot re-upload logic and adds output handlers for single IAP localization responses. The IAP image and review screenshot update commands previously failed for existing assets because GET requests do not provide upload operations. The fix now creates a new upload reservation, uploads the file, commits it, and then deletes the old asset. Additionally, `*InAppPurchaseLocalizationResponse` was missing from markdown and table output handlers, causing "unsupported type" errors for create/update operations. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>