[PR #350] [MERGED] Subscriptions sub-resources parity #461

New issue

Closed

opened 2026-02-26 22:31:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/350
Author: @rudrankriyam
Created: 1/30/2026
Status: ✅ Merged
Merged: 1/31/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/subscriptions-sub-resources-parity-9e2b

📝 Commits (5)

f0016cd Add subscription subresource client support
98d610a Add subscription subresource CLI commands
febbe6c Fix subscriptions submit imports
673a75f Fix subscription offer test relationship checks
e48ed25 Use shared asset delete result type

📊 Changes

20 files changed (+6207 additions, -0 deletions)

View changed files

📝 internal/asc/client_pagination.go (+20 -0)
➕ internal/asc/client_subscription_resources.go (+1095 -0)
📝 internal/asc/client_types.go (+11 -0)
➕ internal/asc/subscription_resources.go (+454 -0)
➕ internal/asc/subscription_resources_queries.go (+316 -0)
➕ internal/asc/subscriptions_resources_http_test.go (+1001 -0)
📝 internal/asc/win_back_offers.go (+17 -0)
📝 internal/cli/cmdtest/commands_test.go (+185 -0)
➕ internal/cli/subscriptions/group_localizations.go (+334 -0)
➕ internal/cli/subscriptions/helpers.go (+145 -0)
➕ internal/cli/subscriptions/images.go (+352 -0)
➕ internal/cli/subscriptions/introductory_offers.go (+370 -0)
➕ internal/cli/subscriptions/localizations.go (+334 -0)
➕ internal/cli/subscriptions/offer_codes.go (+548 -0)
➕ internal/cli/subscriptions/price_points.go (+202 -0)
➕ internal/cli/subscriptions/promotional_offers.go (+427 -0)
➕ internal/cli/subscriptions/review_screenshots.go (+275 -0)
📝 internal/cli/subscriptions/shared_wrappers.go (+4 -0)
➕ internal/cli/subscriptions/submit.go (+107 -0)
📝 internal/cli/subscriptions/subscriptions.go (+10 -0)

📄 Description

Implement support for managing various subscription sub-resources via the CLI.

This PR adds client methods, types, and CLI commands for subscription localizations, images, introductory offers, promotional offers, offer codes, price points, and submissions, enabling comprehensive management of these resources.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/350 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/30/2026 **Status:** ✅ Merged **Merged:** 1/31/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/subscriptions-sub-resources-parity-9e2b` --- ### 📝 Commits (5) - [`f0016cd`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f0016cdb1b5e2262b8365c8efa671f81fdcb3482) Add subscription subresource client support - [`98d610a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/98d610a7c755a34b632fa9dc08a071269c847978) Add subscription subresource CLI commands - [`febbe6c`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/febbe6c3a94c310184ea4575df8bd93f0b114e65) Fix subscriptions submit imports - [`673a75f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/673a75f0a5aa65274bd9c7a1b07488c36ade246f) Fix subscription offer test relationship checks - [`e48ed25`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e48ed2554216870e87773e3391f8a166acc4bbe7) Use shared asset delete result type ### 📊 Changes **20 files changed** (+6207 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_pagination.go` (+20 -0) ➕ `internal/asc/client_subscription_resources.go` (+1095 -0) 📝 `internal/asc/client_types.go` (+11 -0) ➕ `internal/asc/subscription_resources.go` (+454 -0) ➕ `internal/asc/subscription_resources_queries.go` (+316 -0) ➕ `internal/asc/subscriptions_resources_http_test.go` (+1001 -0) 📝 `internal/asc/win_back_offers.go` (+17 -0) 📝 `internal/cli/cmdtest/commands_test.go` (+185 -0) ➕ `internal/cli/subscriptions/group_localizations.go` (+334 -0) ➕ `internal/cli/subscriptions/helpers.go` (+145 -0) ➕ `internal/cli/subscriptions/images.go` (+352 -0) ➕ `internal/cli/subscriptions/introductory_offers.go` (+370 -0) ➕ `internal/cli/subscriptions/localizations.go` (+334 -0) ➕ `internal/cli/subscriptions/offer_codes.go` (+548 -0) ➕ `internal/cli/subscriptions/price_points.go` (+202 -0) ➕ `internal/cli/subscriptions/promotional_offers.go` (+427 -0) ➕ `internal/cli/subscriptions/review_screenshots.go` (+275 -0) 📝 `internal/cli/subscriptions/shared_wrappers.go` (+4 -0) ➕ `internal/cli/subscriptions/submit.go` (+107 -0) 📝 `internal/cli/subscriptions/subscriptions.go` (+10 -0) </details> ### 📄 Description Implement support for managing various subscription sub-resources via the CLI. This PR adds client methods, types, and CLI commands for subscription localizations, images, introductory offers, promotional offers, offer codes, price points, and submissions, enabling comprehensive management of these resources. --- <a href="https://cursor.com/background-agent?bcId=bc-9d785832-9e3f-464e-9dd0-ac25929960f8"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-9d785832-9e3f-464e-9dd0-ac25929960f8"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>