[GH-ISSUE #165] Audit: Add nil check to IsUnauthorized helper #46

New issue

Closed

opened 2026-02-26 21:32:59 +03:00 by kerem · 1 comment

kerem commented

2026-02-26 21:32:59 +03:00

Owner

Originally created by @rudrankriyam on GitHub (Jan 25, 2026).
Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/165

Description

internal/asc/client_http.go:444-446 can panic if err is nil:

func IsUnauthorized(err error) bool {
    return strings.Contains(err.Error(), "UNAUTHORIZED")
}

Impact

Runtime panic on nil error

Location

internal/asc/client_http.go:444-446

Fix

Add nil check:

func IsUnauthorized(err error) bool {
    if err == nil {
        return false
    }
    return strings.Contains(err.Error(), "UNAUTHORIZED")
}

Severity

Medium

Originally created by @rudrankriyam on GitHub (Jan 25, 2026). Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/165 ## Description `internal/asc/client_http.go:444-446` can panic if `err` is nil: ```go func IsUnauthorized(err error) bool { return strings.Contains(err.Error(), "UNAUTHORIZED") } ``` ## Impact - Runtime panic on nil error ## Location `internal/asc/client_http.go:444-446` ## Fix Add nil check: ```go func IsUnauthorized(err error) bool { if err == nil { return false } return strings.Contains(err.Error(), "UNAUTHORIZED") } ``` ## Severity Medium