[PR #315] [MERGED] JSON omitempty zero values #441

New issue

Closed

opened 2026-02-26 22:30:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:30:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/315
Author: @cursor[bot]
Created: 1/30/2026
Status: ✅ Merged
Merged: 1/30/2026
Merged by: @rudrankriyam

Base: cursor/product-pages-cli-support-3c10 ← Head: cursor/json-omitempty-zero-values-a8e5

📝 Commits (2)

a64ceec Fix json output for product page fields
72a15cc Reuse optional int formatter

📊 Changes

4 files changed (+27 additions, -23 deletions)

View changed files

📝 internal/asc/client_product_pages.go (+1 -1)
📝 internal/asc/client_product_pages_experiments.go (+4 -4)
📝 internal/asc/output_product_pages.go (+12 -12)
📝 internal/asc/output_product_pages_test.go (+10 -6)

📄 Description

Convert bool and int fields to pointer types (*bool, *int) in response structs to prevent zero values from being omitted in JSON output due to omitempty.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/315 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/30/2026 **Status:** ✅ Merged **Merged:** 1/30/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `cursor/product-pages-cli-support-3c10` ← **Head:** `cursor/json-omitempty-zero-values-a8e5` --- ### 📝 Commits (2) - [`a64ceec`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a64ceecf6218ce6b7e5ef4c1dc88a67ba05b3238) Fix json output for product page fields - [`72a15cc`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/72a15cc26f8334826fad29499cf2d1172fb43d7c) Reuse optional int formatter ### 📊 Changes **4 files changed** (+27 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_product_pages.go` (+1 -1) 📝 `internal/asc/client_product_pages_experiments.go` (+4 -4) 📝 `internal/asc/output_product_pages.go` (+12 -12) 📝 `internal/asc/output_product_pages_test.go` (+10 -6) </details> ### 📄 Description Convert `bool` and `int` fields to pointer types (`*bool`, `*int`) in response structs to prevent zero values from being omitted in JSON output due to `omitempty`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>