[PR #310] [MERGED] Product pages CLI support #434

New issue

Closed

opened 2026-02-26 22:30:55 +03:00 by kerem · 0 comments

kerem commented 2026-02-26 22:30:55 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/310
Author: @rudrankriyam
Created: 1/30/2026
Status: ✅ Merged
Merged: 1/30/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/product-pages-cli-support-3c10

---

📝 Commits (10+)

• fc4dee8 Add product pages CLI/client tests
• af53adc Add product pages CLI support
• d587fc8 Fix experiments flag validation order
• 22a38e4 Fix pagination type validation cases
• eaee032 Merge pull request #312 from rudrankriyam/cursor/client-pagination-typeof-cases-a1e8
• a64ceec Fix json output for product page fields
• 72a15cc Reuse optional int formatter
• c0dd008 Merge pull request #315 from rudrankriyam/cursor/json-omitempty-zero-values-a8e5
• 84193d2 Fix product pages validation and spec alignment.
• f70d7c0 Test empty product pages outputs.

📊 Changes

21 files changed (+5788 additions, -115 deletions)

View changed files

📝 internal/asc/client_options.go (+161 -0)
📝 internal/asc/client_pagination.go (+28 -0)
➕ internal/asc/client_product_pages.go (+591 -0)
➕ internal/asc/client_product_pages_experiments.go (+765 -0)
➕ internal/asc/client_product_pages_test.go (+858 -0)
📝 internal/asc/client_queries.go (+74 -0)
📝 internal/asc/client_types.go (+118 -115)
📝 internal/asc/output_core.go (+76 -0)
➕ internal/asc/output_product_pages.go (+269 -0)
➕ internal/asc/output_product_pages_test.go (+568 -0)
➕ internal/cli/cmdtest/product_pages_test.go (+180 -0)
➕ internal/cli/productpages/commands.go (+8 -0)
➕ internal/cli/productpages/custom_page_localizations.go (+315 -0)
➕ internal/cli/productpages/custom_page_versions.go (+258 -0)
➕ internal/cli/productpages/custom_pages.go (+325 -0)
➕ internal/cli/productpages/experiment_treatment_localizations.go (+258 -0)
➕ internal/cli/productpages/experiment_treatments.go (+323 -0)
➕ internal/cli/productpages/experiments.go (+532 -0)
➕ internal/cli/productpages/product_pages.go (+37 -0)
➕ internal/cli/productpages/shared_wrappers.go (+42 -0)

...and 1 more files

📄 Description

Implement asc product-pages command group to manage custom product pages, versions, localizations, experiments (v1/v2), treatments, and treatment localizations.

This PR adds comprehensive CLI and client support for the new product-pages resource group, including pagination, formatted output, and extensive testing, as requested in the issue.

---

 

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/310 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/30/2026 **Status:** ✅ Merged **Merged:** 1/30/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/product-pages-cli-support-3c10` --- ### 📝 Commits (10+) - [`fc4dee8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/fc4dee808d440b8efc17f388bb00fc03b51d9c47) Add product pages CLI/client tests - [`af53adc`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/af53adc498cef8aa0735af3a24dae5d73853505b) Add product pages CLI support - [`d587fc8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d587fc8e08c2d85f218463a085ab20c3c6d06086) Fix experiments flag validation order - [`22a38e4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/22a38e4eca9fcdace6dfa25d449bbf7dbad3b238) Fix pagination type validation cases - [`eaee032`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/eaee0329885c7ed81b19be7db96db45fba901579) Merge pull request #312 from rudrankriyam/cursor/client-pagination-typeof-cases-a1e8 - [`a64ceec`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a64ceecf6218ce6b7e5ef4c1dc88a67ba05b3238) Fix json output for product page fields - [`72a15cc`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/72a15cc26f8334826fad29499cf2d1172fb43d7c) Reuse optional int formatter - [`c0dd008`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/c0dd0084b02065e060ef129eb6161f77b73fc1f4) Merge pull request #315 from rudrankriyam/cursor/json-omitempty-zero-values-a8e5 - [`84193d2`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/84193d2bb92b60c6ffa4958bfdccfdd1979bff0e) Fix product pages validation and spec alignment. - [`f70d7c0`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f70d7c0fa6f00d872cabfca5800b9fe5b921c45f) Test empty product pages outputs. ### 📊 Changes **21 files changed** (+5788 additions, -115 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_options.go` (+161 -0) 📝 `internal/asc/client_pagination.go` (+28 -0) ➕ `internal/asc/client_product_pages.go` (+591 -0) ➕ `internal/asc/client_product_pages_experiments.go` (+765 -0) ➕ `internal/asc/client_product_pages_test.go` (+858 -0) 📝 `internal/asc/client_queries.go` (+74 -0) 📝 `internal/asc/client_types.go` (+118 -115) 📝 `internal/asc/output_core.go` (+76 -0) ➕ `internal/asc/output_product_pages.go` (+269 -0) ➕ `internal/asc/output_product_pages_test.go` (+568 -0) ➕ `internal/cli/cmdtest/product_pages_test.go` (+180 -0) ➕ `internal/cli/productpages/commands.go` (+8 -0) ➕ `internal/cli/productpages/custom_page_localizations.go` (+315 -0) ➕ `internal/cli/productpages/custom_page_versions.go` (+258 -0) ➕ `internal/cli/productpages/custom_pages.go` (+325 -0) ➕ `internal/cli/productpages/experiment_treatment_localizations.go` (+258 -0) ➕ `internal/cli/productpages/experiment_treatments.go` (+323 -0) ➕ `internal/cli/productpages/experiments.go` (+532 -0) ➕ `internal/cli/productpages/product_pages.go` (+37 -0) ➕ `internal/cli/productpages/shared_wrappers.go` (+42 -0) _...and 1 more files_ </details> ### 📄 Description Implement `asc product-pages` command group to manage custom product pages, versions, localizations, experiments (v1/v2), treatments, and treatment localizations. This PR adds comprehensive CLI and client support for the new `product-pages` resource group, including pagination, formatted output, and extensive testing, as requested in the issue. --- <a href="https://cursor.com/background-agent?bcId=bc-1b901048-c432-4b24-b75f-b70edbfbf4d8"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-1b901048-c432-4b24-b75f-b70edbfbf4d8"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem 2026-02-26 22:30:55 +03:00

• closed this issue
• added the
  pull-request
  label

kerem referenced this issue 2026-02-26 22:31:22 +03:00

[PR #436] [MERGED] migrate: follow-up hardening for appInfo selection #524

kerem referenced this issue 2026-02-26 22:31:22 +03:00

[PR #434] [MERGED] Fix migrate import: omit locale on PATCH + select draft AppInfo #525

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.1

1.1.0

1.0.1

1.0.0

0.49.1

0.49.0

0.48.1

0.48.0

0.47.1

0.47.0

0.46.2

0.46.1

0.46.0

0.45.4

0.45.3

0.45.2

0.45.1

0.45.0

0.44.2

0.44.1

0.44.0

0.43.0

0.42.0

0.41.4

0.41.3

0.41.2

0.41.1

0.41.0

0.40.1

0.40.0

0.39.1

0.39.0

0.38.3

0.38.2

0.38.1

0.38.0

0.37.3

0.37.2

0.37.1

0.37.0

0.36.3

0.36.2

0.36.1

0.36.0

0.35.3

0.35.2

0.35.1

0.35.0

0.34.1

0.34.0

0.33.2

0.33.1

0.33.0

0.32.0

0.31.3

0.31.2

0.31.1

0.31.0

0.30.0

0.29.3

0.29.2

0.29.1

0.29.0

0.28.14

0.28.13

0.28.12

0.28.11

0.28.10

0.28.9

0.28.8

0.28.7

0.28.6

0.28.5

0.28.4

0.28.3

0.28.2

0.28.1

0.28.0

0.27.0

0.26.4

0.26.3

0.26.2

0.26.1

0.26.0

0.25.4

0.25.3

0.25.1

0.25.0

0.24.3

0.24.2

0.24.1

0.24.0

0.23.5

0.23.4

0.23.3

0.23.2

0.23.1

0.23.0

0.22.1

0.22.0

0.21.0

0.20.2

0.20.1

0.20.0

0.19.3

0.19.2

0.19.1

0.19.0

0.18.2

0.18.1

0.18.0

0.17.0

0.16.0

0.15.0

0.14.0

0.13.0

0.12.4

0.12.3

0.12.2

0.12.1

0.12.0

0.11.0

0.10.2

0.10.1

0.10.0

0.9.0

0.8.1

0.8.0

0.7.0

0.6.0

0.5.0

0.3.1

0.3.0

0.2.0

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

Labels

Clear labels   

bug

  

bug

  

documentation

  

enhancement

  

pull-request

Mirrored from GitHub Pull Request

No labels

bug

bug

documentation

enhancement

pull-request

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/App-Store-Connect-CLI#434

No description provided.