[GH-ISSUE #162] Audit: Fix nil pointer dereference risk in shared.go #43

New issue

Closed

opened 2026-02-26 21:32:58 +03:00 by kerem · 1 comment

kerem commented

2026-02-26 21:32:58 +03:00

Owner

Originally created by @rudrankriyam on GitHub (Jan 25, 2026).
Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/162

Description

cmd/shared.go:174-178 has a potential nil pointer dereference:

cfg, err := config.Load()
if err != nil {
    return ""
}
return strings.TrimSpace(cfg.AppID)

If config.Load() returns nil, nil (when config file doesn't exist), the subsequent access to cfg.AppID will panic.

Impact

Runtime panic when config file doesn't exist
User-facing crash instead of graceful handling

Location

cmd/shared.go:174-178

Fix

Add explicit nil check for cfg:

cfg, err := config.Load()
if err != nil {
    return ""
}
if cfg == nil {
    return ""
}
return strings.TrimSpace(cfg.AppID)

Severity

High

Originally created by @rudrankriyam on GitHub (Jan 25, 2026). Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/162 ## Description `cmd/shared.go:174-178` has a potential nil pointer dereference: ```go cfg, err := config.Load() if err != nil { return "" } return strings.TrimSpace(cfg.AppID) ``` If `config.Load()` returns `nil, nil` (when config file doesn't exist), the subsequent access to `cfg.AppID` will panic. ## Impact - Runtime panic when config file doesn't exist - User-facing crash instead of graceful handling ## Location `cmd/shared.go:174-178` ## Fix Add explicit nil check for `cfg`: ```go cfg, err := config.Load() if err != nil { return "" } if cfg == nil { return "" } return strings.TrimSpace(cfg.AppID) ``` ## Severity High