[PR #299] [MERGED] chore: refresh deps and harden auth/config #424

New issue

Closed

opened 2026-02-26 22:30:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:30:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/299
Author: @rudrankriyam
Created: 1/29/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @rudrankriyam

Base: main ← Head: chore/update-go-deps-ci

📝 Commits (1)

536df69 chore: refresh deps, CI, and auth/config hardening

📊 Changes

19 files changed (+283 additions, -46 deletions)

View changed files

📝 .github/workflows/main-branch.yml (+1 -1)
📝 .github/workflows/pr-checks.yml (+1 -1)
📝 .github/workflows/release.yml (+1 -1)
📝 CONTRIBUTING.md (+1 -1)
📝 README.md (+2 -2)
📝 docs/GO_STANDARDS.md (+6 -0)
📝 go.mod (+6 -6)
📝 go.sum (+14 -18)
📝 internal/asc/client_pagination.go (+1 -1)
📝 internal/asc/client_test.go (+1 -1)
📝 internal/asc/errors.go (+5 -4)
📝 internal/auth/keychain.go (+3 -0)
📝 internal/auth/keychain_test.go (+21 -0)
📝 internal/cli/auth/auth.go (+5 -4)
📝 internal/cli/cmdtest/commands_test.go (+36 -0)
📝 internal/cli/install/install.go (+5 -3)
📝 internal/cli/install/install_test.go (+1 -2)
📝 internal/config/config.go (+102 -1)
📝 internal/config/config_test.go (+71 -0)

📄 Description

Summary

Align Go 1.24 toolchain across modules, docs, and CI with updated dependencies
Harden config parsing (absolute config path, validation bounds) and document empty-result expectations
Make keychain bypass consistent in auth login/status flows and add regression coverage

Test plan

go test -short ./...
make test-integration (skips feedback/crashes and release-request tests when data/ASC_RELEASE_VERSION_ID are missing)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/299 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/29/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `chore/update-go-deps-ci` --- ### 📝 Commits (1) - [`536df69`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/536df696d25d5690fbc897d86acfcf53f8c74297) chore: refresh deps, CI, and auth/config hardening ### 📊 Changes **19 files changed** (+283 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/main-branch.yml` (+1 -1) 📝 `.github/workflows/pr-checks.yml` (+1 -1) 📝 `.github/workflows/release.yml` (+1 -1) 📝 `CONTRIBUTING.md` (+1 -1) 📝 `README.md` (+2 -2) 📝 `docs/GO_STANDARDS.md` (+6 -0) 📝 `go.mod` (+6 -6) 📝 `go.sum` (+14 -18) 📝 `internal/asc/client_pagination.go` (+1 -1) 📝 `internal/asc/client_test.go` (+1 -1) 📝 `internal/asc/errors.go` (+5 -4) 📝 `internal/auth/keychain.go` (+3 -0) 📝 `internal/auth/keychain_test.go` (+21 -0) 📝 `internal/cli/auth/auth.go` (+5 -4) 📝 `internal/cli/cmdtest/commands_test.go` (+36 -0) 📝 `internal/cli/install/install.go` (+5 -3) 📝 `internal/cli/install/install_test.go` (+1 -2) 📝 `internal/config/config.go` (+102 -1) 📝 `internal/config/config_test.go` (+71 -0) </details> ### 📄 Description ## Summary - Align Go 1.24 toolchain across modules, docs, and CI with updated dependencies - Harden config parsing (absolute config path, validation bounds) and document empty-result expectations - Make keychain bypass consistent in auth login/status flows and add regression coverage ## Test plan - [x] `go test -short ./...` - [x] `make test-integration` (skips feedback/crashes and release-request tests when data/ASC_RELEASE_VERSION_ID are missing) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>