[PR #298] [MERGED] Pagination and certificate helpers #423

New issue

Closed

opened 2026-02-26 22:30:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:30:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/298
Author: @cursor[bot]
Created: 1/29/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @rudrankriyam

Base: feat/merchant-ids ← Head: cursor/pagination-and-certificate-helpers-7562

📝 Commits (1)

9b8e808 Fix pagination type checks and share cert helpers

📊 Changes

8 files changed (+124 additions, -116 deletions)

View changed files

📝 internal/asc/client_pagination.go (+2 -0)
📝 internal/cli/merchantids/merchant_ids.go (+0 -45)
📝 internal/cli/merchantids/merchant_ids_certificates.go (+2 -13)
📝 internal/cli/merchantids/shared_wrappers.go (+24 -0)
📝 internal/cli/passtypeids/pass_type_ids.go (+0 -45)
📝 internal/cli/passtypeids/pass_type_ids_certificates.go (+2 -13)
📝 internal/cli/passtypeids/shared_wrappers.go (+24 -0)
➕ internal/cli/shared/certificate_helpers.go (+70 -0)

📄 Description

Add PassTypeIDsResponse to pagination type check and refactor duplicated certificate helper functions into a shared package to improve type validation and reduce code duplication.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/298 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/29/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/merchant-ids` ← **Head:** `cursor/pagination-and-certificate-helpers-7562` --- ### 📝 Commits (1) - [`9b8e808`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/9b8e808004f6ea02dcc7a8000d94b4ac74813cdc) Fix pagination type checks and share cert helpers ### 📊 Changes **8 files changed** (+124 additions, -116 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_pagination.go` (+2 -0) 📝 `internal/cli/merchantids/merchant_ids.go` (+0 -45) 📝 `internal/cli/merchantids/merchant_ids_certificates.go` (+2 -13) 📝 `internal/cli/merchantids/shared_wrappers.go` (+24 -0) 📝 `internal/cli/passtypeids/pass_type_ids.go` (+0 -45) 📝 `internal/cli/passtypeids/pass_type_ids_certificates.go` (+2 -13) 📝 `internal/cli/passtypeids/shared_wrappers.go` (+24 -0) ➕ `internal/cli/shared/certificate_helpers.go` (+70 -0) </details> ### 📄 Description Add `PassTypeIDsResponse` to pagination type check and refactor duplicated certificate helper functions into a shared package to improve type validation and reduce code duplication. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>