[PR #287] [MERGED] Keychain bypass validation consistency #411

New issue

Closed

opened 2026-02-26 22:30:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:30:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/287
Author: @cursor[bot]
Created: 1/29/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @rudrankriyam

Base: fix/test-auth-isolation-clean ← Head: cursor/keychain-bypass-validation-consistency-4c3e

📝 Commits (1)

a195dc4 Align keychain bypass env validation

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 internal/cli/cmdtest/isolation_test.go (+2 -2)

📄 Description

Align ASC_BYPASS_KEYCHAIN environment variable validation in cmdtest with integration_isolation_test.

Previously, cmdtest only checked if ASC_BYPASS_KEYCHAIN was non-empty, while shouldBypassKeychain() and integration_isolation_test require the value to be exactly '1' to enable the bypass. This change ensures consistency, preventing scenarios where the test's guard passes but the keychain bypass is not actually active.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/287 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/29/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `fix/test-auth-isolation-clean` ← **Head:** `cursor/keychain-bypass-validation-consistency-4c3e` --- ### 📝 Commits (1) - [`a195dc4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a195dc49a8ea7c6010b19a6ae5026271c3e3e1fd) Align keychain bypass env validation ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/isolation_test.go` (+2 -2) </details> ### 📄 Description Align `ASC_BYPASS_KEYCHAIN` environment variable validation in `cmdtest` with `integration_isolation_test`. Previously, `cmdtest` only checked if `ASC_BYPASS_KEYCHAIN` was non-empty, while `shouldBypassKeychain()` and `integration_isolation_test` require the value to be exactly '1' to enable the bypass. This change ensures consistency, preventing scenarios where the test's guard passes but the keychain bypass is not actually active. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>