[PR #286] [MERGED] test: isolate auth config during tests #409

New issue

Closed

opened 2026-02-26 22:30:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:30:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/286
Author: @rudrankriyam
Created: 1/29/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @rudrankriyam

Base: main ← Head: fix/test-auth-isolation-clean

📝 Commits (4)

05cbe68 test: isolate auth config during tests
c609ee4 test: bypass keychain in integration auth
a195dc4 Align keychain bypass env validation
09660b7 Merge pull request #287 from rudrankriyam/cursor/keychain-bypass-validation-consistency-4c3e

📊 Changes

6 files changed (+177 additions, -0 deletions)

View changed files

➕ internal/auth/integration_isolation_test.go (+18 -0)
➕ internal/auth/integration_main_test.go (+43 -0)
➕ internal/auth/isolation_test.go (+22 -0)
➕ internal/auth/test_main_test.go (+45 -0)
➕ internal/cli/cmdtest/isolation_test.go (+23 -0)
➕ internal/cli/cmdtest/test_main_test.go (+26 -0)

📄 Description

Summary

add test harnesses for auth and cmdtest to isolate config/keychain usage
enforce ASC_CONFIG_PATH and ASC_BYPASS_KEYCHAIN for test safety
add guard tests to prevent accidental real-config access

Test plan

go test ./internal/auth ./internal/cli/cmdtest

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/286 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/29/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `fix/test-auth-isolation-clean` --- ### 📝 Commits (4) - [`05cbe68`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/05cbe68e9ede227a3acc3da8587c25c64cd860cf) test: isolate auth config during tests - [`c609ee4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/c609ee46763c953249c2c5769ad3df587dbc45eb) test: bypass keychain in integration auth - [`a195dc4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a195dc49a8ea7c6010b19a6ae5026271c3e3e1fd) Align keychain bypass env validation - [`09660b7`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/09660b7b93747a8e5c3a5214ffa20623eebb8d47) Merge pull request #287 from rudrankriyam/cursor/keychain-bypass-validation-consistency-4c3e ### 📊 Changes **6 files changed** (+177 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `internal/auth/integration_isolation_test.go` (+18 -0) ➕ `internal/auth/integration_main_test.go` (+43 -0) ➕ `internal/auth/isolation_test.go` (+22 -0) ➕ `internal/auth/test_main_test.go` (+45 -0) ➕ `internal/cli/cmdtest/isolation_test.go` (+23 -0) ➕ `internal/cli/cmdtest/test_main_test.go` (+26 -0) </details> ### 📄 Description ## Summary - add test harnesses for auth and cmdtest to isolate config/keychain usage - enforce ASC_CONFIG_PATH and ASC_BYPASS_KEYCHAIN for test safety - add guard tests to prevent accidental real-config access ## Test plan - [x] go test ./internal/auth ./internal/cli/cmdtest --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>