[PR #280] [MERGED] refactor: domain-based CLI command structure #407

New issue

Closed

opened 2026-02-26 22:30:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:30:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/280
Author: @rudrankriyam
Created: 1/29/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @rudrankriyam

Base: main ← Head: refactor/cli-phase1

📝 Commits (10+)

6d8c93c refactor: split CLI helpers into internal/cli
6cbd088 refactor: group testflight and signing CLI
ce9c9da refactor: move builds CLI into domain package
7dc9114 refactor: group app commands in apps domain
28146dc refactor: move localizations command into domain
9859991 refactor: move analytics CLI into domain
606e67a refactor: split performance and xcode cloud CLI
2b2e9a3 docs: document CLI command builder phase
2fa3ec2 refactor: move assets and offer codes into domains
1631203 refactor: move reviews CLI into domain

📊 Changes

242 files changed (+7807 additions, -4983 deletions)

View changed files

📝 Agents.md (+1 -1)
➖ cmd/assets.go (+0 -786)
📝 cmd/errors.go (+4 -24)
➖ cmd/performance.go (+0 -688)
📝 cmd/root.go (+11 -72)
📝 cmd/shared.go (+21 -508)
➖ cmd/xcode_cloud.go (+0 -1731)
📝 docs/CONTRIBUTING.md (+13 -5)
📝 internal/asc/integration_test.go (+6 -3)
📝 internal/auth/keychain.go (+39 -39)
📝 internal/cli/accessibility/accessibility.go (+1 -1)
➕ internal/cli/accessibility/commands.go (+8 -0)
➕ internal/cli/accessibility/shared_wrappers.go (+46 -0)
📝 internal/cli/actors/actors.go (+1 -1)
➕ internal/cli/actors/commands.go (+8 -0)
➕ internal/cli/actors/shared_wrappers.go (+34 -0)
📝 internal/cli/agerating/age_rating.go (+1 -14)
➕ internal/cli/agerating/commands.go (+8 -0)
➕ internal/cli/agerating/shared_wrappers.go (+34 -0)
📝 internal/cli/analytics/analytics.go (+1 -1)

...and 80 more files

📄 Description

Summary

move CLI command implementations into internal/cli/<domain> packages and remove cmd/ wrappers
centralize root wiring in internal/cli/registry and shared helpers in internal/cli/shared
relocate root-level tests into internal/cli/cmdtest and document the new CLI structure

Test plan

make build
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/280 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/29/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `refactor/cli-phase1` --- ### 📝 Commits (10+) - [`6d8c93c`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6d8c93c882008b9f4c674332a4c967fc3c556430) refactor: split CLI helpers into internal/cli - [`6cbd088`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6cbd08822f7d7855f9da91823ad93635e1987b02) refactor: group testflight and signing CLI - [`ce9c9da`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/ce9c9dab786f2123aeb4950e79be10f2aa3a689e) refactor: move builds CLI into domain package - [`7dc9114`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7dc91140284bf58833efca132502a44a967ca03f) refactor: group app commands in apps domain - [`28146dc`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/28146dcca92c3229fc925479d4310451fc0d310f) refactor: move localizations command into domain - [`9859991`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/9859991a2687147fc33f66dcadfe3e1e5003a5c9) refactor: move analytics CLI into domain - [`606e67a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/606e67a29d46b6fee3b976670f8d373b59aabba5) refactor: split performance and xcode cloud CLI - [`2b2e9a3`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/2b2e9a3b12c8d51ba49791b7b87b3fbcae44a61b) docs: document CLI command builder phase - [`2fa3ec2`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/2fa3ec21160a8e164d2507c4555a28d6132ed54a) refactor: move assets and offer codes into domains - [`1631203`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/1631203424a0a8a065b3fa5d08869e5494c58b16) refactor: move reviews CLI into domain ### 📊 Changes **242 files changed** (+7807 additions, -4983 deletions) <details> <summary>View changed files</summary> 📝 `Agents.md` (+1 -1) ➖ `cmd/assets.go` (+0 -786) 📝 `cmd/errors.go` (+4 -24) ➖ `cmd/performance.go` (+0 -688) 📝 `cmd/root.go` (+11 -72) 📝 `cmd/shared.go` (+21 -508) ➖ `cmd/xcode_cloud.go` (+0 -1731) 📝 `docs/CONTRIBUTING.md` (+13 -5) 📝 `internal/asc/integration_test.go` (+6 -3) 📝 `internal/auth/keychain.go` (+39 -39) 📝 `internal/cli/accessibility/accessibility.go` (+1 -1) ➕ `internal/cli/accessibility/commands.go` (+8 -0) ➕ `internal/cli/accessibility/shared_wrappers.go` (+46 -0) 📝 `internal/cli/actors/actors.go` (+1 -1) ➕ `internal/cli/actors/commands.go` (+8 -0) ➕ `internal/cli/actors/shared_wrappers.go` (+34 -0) 📝 `internal/cli/agerating/age_rating.go` (+1 -14) ➕ `internal/cli/agerating/commands.go` (+8 -0) ➕ `internal/cli/agerating/shared_wrappers.go` (+34 -0) 📝 `internal/cli/analytics/analytics.go` (+1 -1) _...and 80 more files_ </details> ### 📄 Description ## Summary - move CLI command implementations into `internal/cli/<domain>` packages and remove `cmd/` wrappers - centralize root wiring in `internal/cli/registry` and shared helpers in `internal/cli/shared` - relocate root-level tests into `internal/cli/cmdtest` and document the new CLI structure ## Test plan - [ ] `make build` - [ ] `make lint` - [ ] `make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>