[PR #278] [MERGED] Fix: align Game Center with OpenAPI #403

New issue

Closed

opened 2026-02-26 22:30:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:30:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/278
Author: @rudrankriyam
Created: 1/28/2026
Status: ✅ Merged
Merged: 1/28/2026
Merged by: @rudrankriyam

Base: main ← Head: pr-153-game-center

📝 Commits (3)

7fefa84 Fix: align Game Center with OpenAPI
22814bb Validate leaderboard set localization name
3c99fa1 Merge pull request #279 from rudrankriyam/cursor/leaderboard-set-localization-name-validation-81a0

📊 Changes

14 files changed (+294 additions, -296 deletions)

View changed files

📝 cmd/game_center_achievements.go (+27 -10)
📝 cmd/game_center_achievements_test.go (+47 -85)
📝 cmd/game_center_leaderboard_localizations.go (+38 -9)
📝 cmd/game_center_leaderboard_sets.go (+17 -6)
📝 cmd/game_center_leaderboard_sets_test.go (+11 -28)
📝 cmd/game_center_leaderboards.go (+10 -5)
📝 cmd/game_center_leaderboards_test.go (+26 -53)
📝 internal/asc/assets_upload_test.go (+4 -5)
📝 internal/asc/game_center_achievements.go (+22 -19)
📝 internal/asc/game_center_leaderboard_localizations_test.go (+9 -4)
📝 internal/asc/game_center_leaderboard_sets.go (+2 -2)
📝 internal/asc/game_center_leaderboards.go (+50 -41)
📝 internal/asc/output_game_center.go (+13 -11)
📝 internal/asc/review_submissions_test.go (+18 -18)

📄 Description

Summary

align Game Center models/flags with OpenAPI required and optional fields
allow list pagination to work with --next without app lookup
harden tests per GO_STANDARDS (avoid error-string matching)

Test plan

make build
make lint
make test
make test-coverage
make test-integration (failed: missing resources/permissions)
asc apps list --name "Chroma"
asc game-center achievements list --app "1500196580" --output table
asc game-center leaderboards list --app "1500196580" --output table
asc game-center leaderboard-sets list --app "1500196580" --output table

Integration test failures:

app_store_version_localizations / feedback / crashes: missing resources for app id 6757997449
reviews: API key lacks permission
builds: no build data
release request test skipped (ASC_RELEASE_VERSION_ID not set)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/278 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/28/2026 **Status:** ✅ Merged **Merged:** 1/28/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `pr-153-game-center` --- ### 📝 Commits (3) - [`7fefa84`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7fefa84b8df0ebeb69adac40f27712aedc756a7a) Fix: align Game Center with OpenAPI - [`22814bb`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/22814bbcd7228b603a5aaa5439b56eca3a95665d) Validate leaderboard set localization name - [`3c99fa1`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3c99fa1d97941f749dc4ba877fd70a9508d7b883) Merge pull request #279 from rudrankriyam/cursor/leaderboard-set-localization-name-validation-81a0 ### 📊 Changes **14 files changed** (+294 additions, -296 deletions) <details> <summary>View changed files</summary> 📝 `cmd/game_center_achievements.go` (+27 -10) 📝 `cmd/game_center_achievements_test.go` (+47 -85) 📝 `cmd/game_center_leaderboard_localizations.go` (+38 -9) 📝 `cmd/game_center_leaderboard_sets.go` (+17 -6) 📝 `cmd/game_center_leaderboard_sets_test.go` (+11 -28) 📝 `cmd/game_center_leaderboards.go` (+10 -5) 📝 `cmd/game_center_leaderboards_test.go` (+26 -53) 📝 `internal/asc/assets_upload_test.go` (+4 -5) 📝 `internal/asc/game_center_achievements.go` (+22 -19) 📝 `internal/asc/game_center_leaderboard_localizations_test.go` (+9 -4) 📝 `internal/asc/game_center_leaderboard_sets.go` (+2 -2) 📝 `internal/asc/game_center_leaderboards.go` (+50 -41) 📝 `internal/asc/output_game_center.go` (+13 -11) 📝 `internal/asc/review_submissions_test.go` (+18 -18) </details> ### 📄 Description ## Summary - align Game Center models/flags with OpenAPI required and optional fields - allow list pagination to work with `--next` without app lookup - harden tests per GO_STANDARDS (avoid error-string matching) ## Test plan - [x] make build - [x] make lint - [x] make test - [x] make test-coverage - [x] make test-integration (failed: missing resources/permissions) - [x] asc apps list --name \"Chroma\" - [x] asc game-center achievements list --app \"1500196580\" --output table - [x] asc game-center leaderboards list --app \"1500196580\" --output table - [x] asc game-center leaderboard-sets list --app \"1500196580\" --output table Integration test failures: - app_store_version_localizations / feedback / crashes: missing resources for app id 6757997449 - reviews: API key lacks permission - builds: no build data - release request test skipped (ASC_RELEASE_VERSION_ID not set) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>