[PR #258] [MERGED] Fix performance pretty output and downloads #389

Closed
opened 2026-02-26 22:30:43 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/258
Author: @rudrankriyam
Created: 1/28/2026
Status: Merged
Merged: 1/28/2026
Merged by: @rudrankriyam

Base: mainHead: pr-254-performance-followup


📝 Commits (1)

  • 0e33e05 Improve performance output formatting

📊 Changes

2 files changed (+71 additions, -12 deletions)

View changed files

📝 cmd/performance.go (+47 -12)
📝 internal/asc/output_core.go (+24 -0)

📄 Description

Summary

  • pretty-print raw performance metrics and diagnostic logs JSON when using --pretty
  • skip gzip decompression when downloads are not gzip, so --decompress doesn’t error
  • keep download output paths consistent with actual compression

Test plan

  • make test

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/258 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/28/2026 **Status:** ✅ Merged **Merged:** 1/28/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `pr-254-performance-followup` --- ### 📝 Commits (1) - [`0e33e05`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0e33e056326d2050f43a993aa718f155505a6e49) Improve performance output formatting ### 📊 Changes **2 files changed** (+71 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `cmd/performance.go` (+47 -12) 📝 `internal/asc/output_core.go` (+24 -0) </details> ### 📄 Description ## Summary - pretty-print raw performance metrics and diagnostic logs JSON when using `--pretty` - skip gzip decompression when downloads are not gzip, so `--decompress` doesn’t error - keep download output paths consistent with actual compression ## Test plan - [x] make test --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 22:30:43 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/App-Store-Connect-CLI#389
No description provided.