[PR #254] [MERGED] Add performance metrics and diagnostics support #385

New issue

Closed

opened 2026-02-26 22:30:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:30:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/254
Author: @rudrankriyam
Created: 1/28/2026
Status: ✅ Merged
Merged: 1/28/2026
Merged by: @rudrankriyam

Base: main ← Head: pr-157-performance

📝 Commits (1)

5aa89e0 Add performance metrics and diagnostics support

📊 Changes

14 files changed (+1646 additions, -0 deletions)

View changed files

📝 cmd/commands_test.go (+87 -0)
➕ cmd/performance.go (+653 -0)
📝 cmd/root.go (+1 -0)
📝 internal/asc/client_http_test.go (+87 -0)
📝 internal/asc/client_options.go (+71 -0)
📝 internal/asc/client_pagination.go (+4 -0)
➕ internal/asc/client_performance.go (+206 -0)
📝 internal/asc/client_queries.go (+38 -0)
📝 internal/asc/client_test.go (+53 -0)
📝 internal/asc/client_types.go (+1 -0)
📝 internal/asc/output_core.go (+16 -0)
➕ internal/asc/output_performance.go (+235 -0)
📝 internal/asc/output_test.go (+103 -0)
➕ internal/asc/performance.go (+91 -0)

📄 Description

Summary

add asc performance command group with metrics, diagnostics, and download subcommands
add ASC client support for perf power metrics and diagnostic signatures/logs
add output summaries plus tests for queries, HTTP requests, outputs, and validation

Test plan

make build
make test
make lint
ASC_BYPASS_KEYCHAIN=1 go run . performance metrics list --app "1500196580"
ASC_BYPASS_KEYCHAIN=1 go run . performance metrics get --build "9c065f3d-f897-43a0-82da-f04b1c057173"
ASC_BYPASS_KEYCHAIN=1 go run . performance diagnostics list --build "9c065f3d-f897-43a0-82da-f04b1c057173" --limit 10 --output json
ASC_BYPASS_KEYCHAIN=1 go run . performance diagnostics get --id "DIAGNOSTIC_ID" --limit 1 (no signatures available)

Fixes #157

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/254 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/28/2026 **Status:** ✅ Merged **Merged:** 1/28/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `pr-157-performance` --- ### 📝 Commits (1) - [`5aa89e0`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/5aa89e043bff59ba45244b586bfdd2022d9d7ff5) Add performance metrics and diagnostics support ### 📊 Changes **14 files changed** (+1646 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `cmd/commands_test.go` (+87 -0) ➕ `cmd/performance.go` (+653 -0) 📝 `cmd/root.go` (+1 -0) 📝 `internal/asc/client_http_test.go` (+87 -0) 📝 `internal/asc/client_options.go` (+71 -0) 📝 `internal/asc/client_pagination.go` (+4 -0) ➕ `internal/asc/client_performance.go` (+206 -0) 📝 `internal/asc/client_queries.go` (+38 -0) 📝 `internal/asc/client_test.go` (+53 -0) 📝 `internal/asc/client_types.go` (+1 -0) 📝 `internal/asc/output_core.go` (+16 -0) ➕ `internal/asc/output_performance.go` (+235 -0) 📝 `internal/asc/output_test.go` (+103 -0) ➕ `internal/asc/performance.go` (+91 -0) </details> ### 📄 Description ## Summary - add `asc performance` command group with metrics, diagnostics, and download subcommands - add ASC client support for perf power metrics and diagnostic signatures/logs - add output summaries plus tests for queries, HTTP requests, outputs, and validation ## Test plan - [x] make build - [x] make test - [x] make lint - [x] ASC_BYPASS_KEYCHAIN=1 go run . performance metrics list --app "1500196580" - [x] ASC_BYPASS_KEYCHAIN=1 go run . performance metrics get --build "9c065f3d-f897-43a0-82da-f04b1c057173" - [x] ASC_BYPASS_KEYCHAIN=1 go run . performance diagnostics list --build "9c065f3d-f897-43a0-82da-f04b1c057173" --limit 10 --output json - [ ] ASC_BYPASS_KEYCHAIN=1 go run . performance diagnostics get --id "DIAGNOSTIC_ID" --limit 1 (no signatures available) Fixes #157 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>