[PR #236] [MERGED] Pre-orders availability logic #379

New issue

Closed

opened 2026-02-26 22:30:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:30:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/236
Author: @cursor[bot]
Created: 1/27/2026
Status: ✅ Merged
Merged: 1/27/2026
Merged by: @rudrankriyam

Base: pr-199 ← Head: cursor/pre-orders-availability-logic-ef04

📝 Commits (2)

52ae6b1 Fix pre-order availability handling
e478493 Fix pre-orders tests after refactor

📊 Changes

6 files changed (+68 additions, -17 deletions)

View changed files

📝 cmd/pre_orders.go (+19 -11)
📝 cmd/pre_orders_test.go (+1 -1)
📝 internal/asc/client_options.go (+21 -0)
📝 internal/asc/client_pagination.go (+4 -0)
📝 internal/asc/client_pricing.go (+19 -5)
📝 internal/asc/client_queries.go (+4 -0)

📄 Description

Fixes pre-orders enable command by updating availability ID, paginating territory results, removing a duplicate type, and cleaning up dead code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/236 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/27/2026 **Status:** ✅ Merged **Merged:** 1/27/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `pr-199` ← **Head:** `cursor/pre-orders-availability-logic-ef04` --- ### 📝 Commits (2) - [`52ae6b1`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/52ae6b1352135c8679b9d3226a6642a506b9aebb) Fix pre-order availability handling - [`e478493`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e478493d8298ae6d2f381ca76c8017f0a5ca22d3) Fix pre-orders tests after refactor ### 📊 Changes **6 files changed** (+68 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `cmd/pre_orders.go` (+19 -11) 📝 `cmd/pre_orders_test.go` (+1 -1) 📝 `internal/asc/client_options.go` (+21 -0) 📝 `internal/asc/client_pagination.go` (+4 -0) 📝 `internal/asc/client_pricing.go` (+19 -5) 📝 `internal/asc/client_queries.go` (+4 -0) </details> ### 📄 Description Fixes pre-orders enable command by updating availability ID, paginating territory results, removing a duplicate type, and cleaning up dead code. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>