[PR #229] [MERGED] Pre-orders bug fixes #373

New issue

Closed

opened 2026-02-26 21:34:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/229
Author: @cursor[bot]
Created: 1/27/2026
Status: ✅ Merged
Merged: 1/27/2026
Merged by: @rudrankriyam

Base: pr-199 ← Head: cursor/pre-orders-bug-fixes-dac1

📝 Commits (1)

4c4f5fc Fix pre-orders availability handling

📊 Changes

4 files changed (+24 additions, -23 deletions)

View changed files

📝 cmd/offer_codes.go (+1 -10)
📝 cmd/pre_orders.go (+9 -12)
📝 cmd/pricing.go (+1 -1)
📝 cmd/shared.go (+13 -0)

📄 Description

Fixes a logic bug where a required flag's value was ignored, and refactors duplicated date normalization and error checking logic for improved code quality.

The --available-in-new-territories flag was required but its value was not used in the API call, leading to a misleading user experience. This PR ensures the flag's value is correctly applied. Additionally, duplicated date parsing logic was consolidated into a shared helper, and redundant error checking conditions were removed from multiple call sites.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/229 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/27/2026 **Status:** ✅ Merged **Merged:** 1/27/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `pr-199` ← **Head:** `cursor/pre-orders-bug-fixes-dac1` --- ### 📝 Commits (1) - [`4c4f5fc`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4c4f5fc9f903474d1f0974ef6582be7c567ffd55) Fix pre-orders availability handling ### 📊 Changes **4 files changed** (+24 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `cmd/offer_codes.go` (+1 -10) 📝 `cmd/pre_orders.go` (+9 -12) 📝 `cmd/pricing.go` (+1 -1) 📝 `cmd/shared.go` (+13 -0) </details> ### 📄 Description Fixes a logic bug where a required flag's value was ignored, and refactors duplicated date normalization and error checking logic for improved code quality. The `--available-in-new-territories` flag was required but its value was not used in the API call, leading to a misleading user experience. This PR ensures the flag's value is correctly applied. Additionally, duplicated date parsing logic was consolidated into a shared helper, and redundant error checking conditions were removed from multiple call sites. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>