[PR #225] [MERGED] feat: add pre-orders commands #369

New issue

Closed

opened 2026-02-26 21:34:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/225
Author: @rudrankriyam
Created: 1/27/2026
Status: ✅ Merged
Merged: 1/27/2026
Merged by: @rudrankriyam

Base: main ← Head: pr-199

📝 Commits (7)

a5f5b1b feat: add pre-orders commands
4c4f5fc Fix pre-orders availability handling
0d8dc1e Merge pull request #229 from rudrankriyam/cursor/pre-orders-bug-fixes-dac1
3678c5b Merge main into pr-199
52ae6b1 Fix pre-order availability handling
e478493 Fix pre-orders tests after refactor
8694767 Merge pull request #236 from rudrankriyam/cursor/pre-orders-availability-logic-ef04

📊 Changes

16 files changed (+1159 additions, -12 deletions)

View changed files

📝 cmd/offer_codes.go (+1 -10)
➕ cmd/pre_orders.go (+478 -0)
➕ cmd/pre_orders_test.go (+274 -0)
📝 cmd/pricing.go (+3 -0)
📝 cmd/root.go (+1 -0)
📝 cmd/shared.go (+47 -0)
📝 internal/asc/client_options.go (+21 -0)
📝 internal/asc/client_pagination.go (+4 -0)
📝 internal/asc/client_pricing.go (+118 -2)
📝 internal/asc/client_queries.go (+4 -0)
📝 internal/asc/client_types.go (+1 -0)
📝 internal/asc/output_core.go (+4 -0)
📝 internal/asc/output_test.go (+40 -0)
➕ internal/asc/pre_orders_output.go (+21 -0)
📝 internal/asc/pricing.go (+42 -0)
📝 internal/asc/pricing_test.go (+100 -0)

📄 Description

Summary

add asc pre-orders command group (get/list/enable/update/disable/end)
support territory availability updates and end-preorders request
add output formatting and tests

Test plan

make test
Manual (ASC_BYPASS_KEYCHAIN=1):
- ./asc pre-orders get --app 6740467361 --output table
- ./asc pre-orders list --availability <availability-id-from-get>
- ./asc pre-orders enable --app 6740467361 --territory "USA,GBR" --release-date "2026-02-01" --available-in-new-territories true --output table
- ./asc pre-orders update --territory-availability <ta-id> --release-date "2026-03-01" --output table
- ./asc pre-orders disable --territory-availability <ta-id> --output table
- ./asc pre-orders end --territory-availability "<ta-id-1>,<ta-id-2>" --output table
- ./asc pre-orders get --app 6747745091 --output table
- ./asc pre-orders list --availability <availability-id-from-get>
- ./asc pre-orders enable --app 6747745091 --territory "USA,GBR" --release-date "2026-02-01" --available-in-new-territories true --output table
- ./asc pre-orders update --territory-availability <ta-id> --release-date "2026-03-01" --output table
- ./asc pre-orders disable --territory-availability <ta-id> --output table
- ./asc pre-orders end --territory-availability "<ta-id-1>,<ta-id-2>" --output table
- ./asc pre-orders get --app 6757997449 --output table

Notes

Enable returned "already available" for tested apps; update requires preOrderEnabled=true.
End pre-orders returned a server-side error for tested apps.
Apps without availability return a friendly "availability not found" message.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/225 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/27/2026 **Status:** ✅ Merged **Merged:** 1/27/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `pr-199` --- ### 📝 Commits (7) - [`a5f5b1b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a5f5b1b05418692bbb8d9e3ee5dbd2c229941593) feat: add pre-orders commands - [`4c4f5fc`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4c4f5fc9f903474d1f0974ef6582be7c567ffd55) Fix pre-orders availability handling - [`0d8dc1e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0d8dc1e3e923dba2489260959cef92a4c30879fc) Merge pull request #229 from rudrankriyam/cursor/pre-orders-bug-fixes-dac1 - [`3678c5b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3678c5b6d47805d0f0106c65955cec8bdf157a1a) Merge main into pr-199 - [`52ae6b1`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/52ae6b1352135c8679b9d3226a6642a506b9aebb) Fix pre-order availability handling - [`e478493`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e478493d8298ae6d2f381ca76c8017f0a5ca22d3) Fix pre-orders tests after refactor - [`8694767`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8694767707b75267ed1e9c657df285f9efb8583e) Merge pull request #236 from rudrankriyam/cursor/pre-orders-availability-logic-ef04 ### 📊 Changes **16 files changed** (+1159 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `cmd/offer_codes.go` (+1 -10) ➕ `cmd/pre_orders.go` (+478 -0) ➕ `cmd/pre_orders_test.go` (+274 -0) 📝 `cmd/pricing.go` (+3 -0) 📝 `cmd/root.go` (+1 -0) 📝 `cmd/shared.go` (+47 -0) 📝 `internal/asc/client_options.go` (+21 -0) 📝 `internal/asc/client_pagination.go` (+4 -0) 📝 `internal/asc/client_pricing.go` (+118 -2) 📝 `internal/asc/client_queries.go` (+4 -0) 📝 `internal/asc/client_types.go` (+1 -0) 📝 `internal/asc/output_core.go` (+4 -0) 📝 `internal/asc/output_test.go` (+40 -0) ➕ `internal/asc/pre_orders_output.go` (+21 -0) 📝 `internal/asc/pricing.go` (+42 -0) 📝 `internal/asc/pricing_test.go` (+100 -0) </details> ### 📄 Description ## Summary - add `asc pre-orders` command group (get/list/enable/update/disable/end) - support territory availability updates and end-preorders request - add output formatting and tests ## Test plan - `make test` - Manual (ASC_BYPASS_KEYCHAIN=1): - `./asc pre-orders get --app 6740467361 --output table` - `./asc pre-orders list --availability <availability-id-from-get>` - `./asc pre-orders enable --app 6740467361 --territory "USA,GBR" --release-date "2026-02-01" --available-in-new-territories true --output table` - `./asc pre-orders update --territory-availability <ta-id> --release-date "2026-03-01" --output table` - `./asc pre-orders disable --territory-availability <ta-id> --output table` - `./asc pre-orders end --territory-availability "<ta-id-1>,<ta-id-2>" --output table` - `./asc pre-orders get --app 6747745091 --output table` - `./asc pre-orders list --availability <availability-id-from-get>` - `./asc pre-orders enable --app 6747745091 --territory "USA,GBR" --release-date "2026-02-01" --available-in-new-territories true --output table` - `./asc pre-orders update --territory-availability <ta-id> --release-date "2026-03-01" --output table` - `./asc pre-orders disable --territory-availability <ta-id> --output table` - `./asc pre-orders end --territory-availability "<ta-id-1>,<ta-id-2>" --output table` - `./asc pre-orders get --app 6757997449 --output table` ## Notes - Enable returned "already available" for tested apps; update requires `preOrderEnabled=true`. - End pre-orders returned a server-side error for tested apps. - Apps without availability return a friendly "availability not found" message. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>