[PR #222] [MERGED] refactor: unify review commands #366

New issue

Closed

opened 2026-02-26 21:34:49 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/222
Author: @rudrankriyam
Created: 1/27/2026
Status: ✅ Merged
Merged: 1/27/2026
Merged by: @rudrankriyam

Base: main ← Head: refactor/review-cli-noun-first

📝 Commits (4)

082edfd refactor: add noun-first review commands
0c75b38 refactor: remove legacy review commands
400e4e7 refactor: rename review commands
105bfc6 test: avoid error string matching

📊 Changes

8 files changed (+239 additions, -304 deletions)

View changed files

📝 cmd/commands_test.go (+24 -24)
➕ cmd/review.go (+53 -0)
📝 cmd/review_attachments.go (+45 -74)
📝 cmd/review_details.go (+26 -57)
📝 cmd/review_items.go (+27 -53)
📝 cmd/review_submissions.go (+36 -64)
📝 cmd/review_submissions_test.go (+27 -29)
📝 cmd/root.go (+1 -3)

📄 Description

Summary

replace review-details, review-submissions, and review-items top-level commands with a single asc review parent
rename all review subcommands to noun-first hyphenated forms (no legacy aliases)
update validation tests and usage strings for the new command paths

New command map

Details: asc review details-get|details-for-version|details-create|details-update
Attachments: asc review attachments-list|get|upload|delete
Submissions: asc review submissions-list|get|create|submit
Items: asc review items-list|items-add|items-remove

Test plan

go test ./...

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/222 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/27/2026 **Status:** ✅ Merged **Merged:** 1/27/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `refactor/review-cli-noun-first` --- ### 📝 Commits (4) - [`082edfd`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/082edfdea06848ae2805a93c7e7e441b4cfb24b8) refactor: add noun-first review commands - [`0c75b38`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0c75b38243a61cfa10ddab2bb4611ae2ff3582c7) refactor: remove legacy review commands - [`400e4e7`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/400e4e737188a92644fdf9561f78350ff6dc1912) refactor: rename review commands - [`105bfc6`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/105bfc64e55272d7918fb8a1b54996be21d7c5c1) test: avoid error string matching ### 📊 Changes **8 files changed** (+239 additions, -304 deletions) <details> <summary>View changed files</summary> 📝 `cmd/commands_test.go` (+24 -24) ➕ `cmd/review.go` (+53 -0) 📝 `cmd/review_attachments.go` (+45 -74) 📝 `cmd/review_details.go` (+26 -57) 📝 `cmd/review_items.go` (+27 -53) 📝 `cmd/review_submissions.go` (+36 -64) 📝 `cmd/review_submissions_test.go` (+27 -29) 📝 `cmd/root.go` (+1 -3) </details> ### 📄 Description ## Summary - replace `review-details`, `review-submissions`, and `review-items` top-level commands with a single `asc review` parent - rename all review subcommands to noun-first hyphenated forms (no legacy aliases) - update validation tests and usage strings for the new command paths ## New command map - Details: `asc review details-get|details-for-version|details-create|details-update` - Attachments: `asc review attachments-list|get|upload|delete` - Submissions: `asc review submissions-list|get|create|submit` - Items: `asc review items-list|items-add|items-remove` ## Test plan - [x] go test ./... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>