[PR #218] [MERGED] Add EULA CLI support #362

New issue

Closed

opened 2026-02-26 21:34:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/218
Author: @rudrankriyam
Created: 1/27/2026
Status: ✅ Merged
Merged: 1/27/2026
Merged by: @rudrankriyam

Base: main ← Head: issue-202-eula

📝 Commits (5)

1ae8a78 Add EULA CLI support
a2bea12 Fix eula get app/id exclusivity
c8a70b9 Merge pull request #219 from rudrankriyam/cursor/eula-app-id-resolution-cd0a
3d11316 test: avoid brittle error string checks
1309d28 test: avoid string matching in eula validation

📊 Changes

27 files changed (+1172 additions, -124 deletions)

View changed files

📝 cmd/builds_latest_test.go (+3 -1)
📝 cmd/commands_test.go (+12 -14)
➕ cmd/eula.go (+313 -0)
📝 cmd/finance_test.go (+2 -2)
📝 cmd/ipa_test.go (+0 -4)
📝 cmd/localizations_test.go (+0 -3)
📝 cmd/pricing_test.go (+0 -4)
📝 cmd/root.go (+1 -0)
📝 cmd/shared_test.go (+0 -4)
📝 cmd/signing_fetch_test.go (+4 -4)
📝 cmd/users_test.go (+0 -4)
📝 cmd/versions_test.go (+2 -3)
📝 internal/asc/analytics_test.go (+3 -11)
📝 internal/asc/client_http.go (+7 -13)
📝 internal/asc/client_http_test.go (+12 -25)
📝 internal/asc/client_test.go (+7 -2)
📝 internal/asc/client_types.go (+1 -0)
➕ internal/asc/errors.go (+51 -0)
➕ internal/asc/eula.go (+267 -0)
➕ internal/asc/eula_output.go (+80 -0)

...and 7 more files

📄 Description

Summary

add asc eula get/list/create/update/delete commands with validation
add client types/endpoints for EULA create/update/delete and app lookup
add table/markdown output plus client/output tests

Test plan

make build
make lint
make test
go run . eula get --app 6747745091 --output table (returned empty table)
go run . eula create --app 6747745091 --agreement-text "Test EULA via CLI (temp)" --territory "USA,CAN" --output json
go run . eula get --id d800cead-3dc3-4bc4-9bec-bb1ad22a4a4a --output json
go run . eula update --id d800cead-3dc3-4bc4-9bec-bb1ad22a4a4a --agreement-text "Test EULA via CLI (temp) - updated" --output json
go run . eula delete --id d800cead-3dc3-4bc4-9bec-bb1ad22a4a4a --confirm --output json
go run . eula get --app 6747745091 --output json --pretty (verified empty again)
go run . eula create --app 6748252780 --agreement-text "Test EULA via CLI (temp - zenther)" --territory "USA,CAN" --output json
go run . eula get --id b009421d-ff6b-4515-9fdf-fbec21d146c6 --output json
go run . eula update --id b009421d-ff6b-4515-9fdf-fbec21d146c6 --agreement-text "Test EULA via CLI (temp - zenther) - updated" --output json
go run . eula delete --id b009421d-ff6b-4515-9fdf-fbec21d146c6 --confirm --output json
go run . eula get --app 6748252780 --output json --pretty (verified empty again)
Stress test (3 cycles each, create/get/update/list/delete):
- app 6748252780 (Zenther)
- app 6747745091 (FoundationLab)
- app 6740467361 (Local LLM Chat: Polarixy AI)

Fixes #202

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/218 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/27/2026 **Status:** ✅ Merged **Merged:** 1/27/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `issue-202-eula` --- ### 📝 Commits (5) - [`1ae8a78`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/1ae8a78e13e5d1db0ebe5271f78bfee155d952fb) Add EULA CLI support - [`a2bea12`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a2bea12874ad72f4c6f5528390c0202ccdfd7ebf) Fix eula get app/id exclusivity - [`c8a70b9`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/c8a70b9d52de998b9c0462df814261b03e498131) Merge pull request #219 from rudrankriyam/cursor/eula-app-id-resolution-cd0a - [`3d11316`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3d113163918e44df3677450ef61c8a442c912bca) test: avoid brittle error string checks - [`1309d28`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/1309d28fee10c4a89ca9ee15b4578597fbf48ee9) test: avoid string matching in eula validation ### 📊 Changes **27 files changed** (+1172 additions, -124 deletions) <details> <summary>View changed files</summary> 📝 `cmd/builds_latest_test.go` (+3 -1) 📝 `cmd/commands_test.go` (+12 -14) ➕ `cmd/eula.go` (+313 -0) 📝 `cmd/finance_test.go` (+2 -2) 📝 `cmd/ipa_test.go` (+0 -4) 📝 `cmd/localizations_test.go` (+0 -3) 📝 `cmd/pricing_test.go` (+0 -4) 📝 `cmd/root.go` (+1 -0) 📝 `cmd/shared_test.go` (+0 -4) 📝 `cmd/signing_fetch_test.go` (+4 -4) 📝 `cmd/users_test.go` (+0 -4) 📝 `cmd/versions_test.go` (+2 -3) 📝 `internal/asc/analytics_test.go` (+3 -11) 📝 `internal/asc/client_http.go` (+7 -13) 📝 `internal/asc/client_http_test.go` (+12 -25) 📝 `internal/asc/client_test.go` (+7 -2) 📝 `internal/asc/client_types.go` (+1 -0) ➕ `internal/asc/errors.go` (+51 -0) ➕ `internal/asc/eula.go` (+267 -0) ➕ `internal/asc/eula_output.go` (+80 -0) _...and 7 more files_ </details> ### 📄 Description ## Summary - add `asc eula` get/list/create/update/delete commands with validation - add client types/endpoints for EULA create/update/delete and app lookup - add table/markdown output plus client/output tests ## Test plan - `make build` - `make lint` - `make test` - `go run . eula get --app 6747745091 --output table` (returned empty table) - `go run . eula create --app 6747745091 --agreement-text "Test EULA via CLI (temp)" --territory "USA,CAN" --output json` - `go run . eula get --id d800cead-3dc3-4bc4-9bec-bb1ad22a4a4a --output json` - `go run . eula update --id d800cead-3dc3-4bc4-9bec-bb1ad22a4a4a --agreement-text "Test EULA via CLI (temp) - updated" --output json` - `go run . eula delete --id d800cead-3dc3-4bc4-9bec-bb1ad22a4a4a --confirm --output json` - `go run . eula get --app 6747745091 --output json --pretty` (verified empty again) - `go run . eula create --app 6748252780 --agreement-text "Test EULA via CLI (temp - zenther)" --territory "USA,CAN" --output json` - `go run . eula get --id b009421d-ff6b-4515-9fdf-fbec21d146c6 --output json` - `go run . eula update --id b009421d-ff6b-4515-9fdf-fbec21d146c6 --agreement-text "Test EULA via CLI (temp - zenther) - updated" --output json` - `go run . eula delete --id b009421d-ff6b-4515-9fdf-fbec21d146c6 --confirm --output json` - `go run . eula get --app 6748252780 --output json --pretty` (verified empty again) - Stress test (3 cycles each, create/get/update/list/delete): - app `6748252780` (Zenther) - app `6747745091` (FoundationLab) - app `6740467361` (Local LLM Chat: Polarixy AI) Fixes #202 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>