[PR #182] [MERGED] Profile credential mismatch #346

New issue

Closed

opened 2026-02-26 21:34:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/182
Author: @cursor[bot]
Created: 1/26/2026
Status: ✅ Merged
Merged: 1/26/2026
Merged by: @rudrankriyam

Base: feat/auth-profiles ← Head: cursor/profile-credential-mismatch-5abf

📝 Commits (2)

09587a6 Align legacy config with default profile
d06c574 test: cover legacy default sync

📊 Changes

2 files changed (+113 additions, -1 deletions)

View changed files

📝 internal/auth/keychain.go (+21 -1)
📝 internal/auth/keychain_test.go (+92 -0)

📄 Description

Align legacy credential fields with the default key name to prevent silent use of incorrect credentials when keychain is unavailable.

Previously, auth switch could set DefaultKeyName to a profile stored in the keychain without updating the legacy KeyID, IssuerID, and PrivateKeyPath fields in the config. If the keychain later became unavailable, the system would incorrectly return credentials from a different profile (stored in the legacy fields) under the new default name.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/182 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/26/2026 **Status:** ✅ Merged **Merged:** 1/26/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feat/auth-profiles` ← **Head:** `cursor/profile-credential-mismatch-5abf` --- ### 📝 Commits (2) - [`09587a6`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/09587a6ff5f16254f3a338c5b75cd54fa24e1e1b) Align legacy config with default profile - [`d06c574`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d06c574542e1a5cf774d7afb893f72634fb7dd94) test: cover legacy default sync ### 📊 Changes **2 files changed** (+113 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/auth/keychain.go` (+21 -1) 📝 `internal/auth/keychain_test.go` (+92 -0) </details> ### 📄 Description Align legacy credential fields with the default key name to prevent silent use of incorrect credentials when keychain is unavailable. Previously, `auth switch` could set `DefaultKeyName` to a profile stored in the keychain without updating the legacy `KeyID`, `IssuerID`, and `PrivateKeyPath` fields in the config. If the keychain later became unavailable, the system would incorrectly return credentials from a different profile (stored in the legacy fields) under the new default name. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>