[PR #175] [MERGED] Add device management support #338

New issue

Closed

opened 2026-02-26 21:34:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/175
Author: @rudrankriyam
Created: 1/25/2026
Status: ✅ Merged
Merged: 1/26/2026
Merged by: @rudrankriyam

Base: main ← Head: issue-159-devices

📝 Commits (3)

b27155c feat: add device management support
78617ec test: add read-only devices integration coverage
e926798 docs: document devices CLI usage

📊 Changes

17 files changed (+1245 additions, -1 deletions)

View changed files

📝 README.md (+24 -1)
📝 cmd/commands_test.go (+77 -0)
➕ cmd/devices.go (+399 -0)
📝 cmd/root.go (+1 -0)
📝 docs/API_NOTES.md (+7 -0)
➕ internal/asc/client_devices.go (+118 -0)
📝 internal/asc/client_http_test.go (+164 -0)
📝 internal/asc/client_options.go (+76 -0)
📝 internal/asc/client_pagination.go (+4 -0)
📝 internal/asc/client_queries.go (+36 -0)
📝 internal/asc/client_types.go (+1 -0)
➕ internal/asc/devices.go (+82 -0)
➕ internal/asc/devices_output.go (+43 -0)
➕ internal/asc/devices_test.go (+53 -0)
📝 internal/asc/integration_test.go (+97 -0)
📝 internal/asc/output_core.go (+8 -0)
📝 internal/asc/output_test.go (+55 -0)

📄 Description

Summary

add asc devices list/get/register/update commands with filters, fields, sorting, and pagination
implement devices API client types, queries, pagination support, and table/markdown output
add CLI validation, client query/HTTP, and output tests for devices

Test plan

make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/175 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/25/2026 **Status:** ✅ Merged **Merged:** 1/26/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `issue-159-devices` --- ### 📝 Commits (3) - [`b27155c`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b27155cb6daa738f496a5126c75c5971f150c0ee) feat: add device management support - [`78617ec`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/78617ecaaf15cb340b6b773c8b6c019f189278f4) test: add read-only devices integration coverage - [`e926798`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e9267980bf10ceeabafd48eeeda2badc5fdc1aed) docs: document devices CLI usage ### 📊 Changes **17 files changed** (+1245 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+24 -1) 📝 `cmd/commands_test.go` (+77 -0) ➕ `cmd/devices.go` (+399 -0) 📝 `cmd/root.go` (+1 -0) 📝 `docs/API_NOTES.md` (+7 -0) ➕ `internal/asc/client_devices.go` (+118 -0) 📝 `internal/asc/client_http_test.go` (+164 -0) 📝 `internal/asc/client_options.go` (+76 -0) 📝 `internal/asc/client_pagination.go` (+4 -0) 📝 `internal/asc/client_queries.go` (+36 -0) 📝 `internal/asc/client_types.go` (+1 -0) ➕ `internal/asc/devices.go` (+82 -0) ➕ `internal/asc/devices_output.go` (+43 -0) ➕ `internal/asc/devices_test.go` (+53 -0) 📝 `internal/asc/integration_test.go` (+97 -0) 📝 `internal/asc/output_core.go` (+8 -0) 📝 `internal/asc/output_test.go` (+55 -0) </details> ### 📄 Description ## Summary - add `asc devices` list/get/register/update commands with filters, fields, sorting, and pagination - implement devices API client types, queries, pagination support, and table/markdown output - add CLI validation, client query/HTTP, and output tests for devices ## Test plan - [x] make test --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>