[PR #173] [MERGED] audit: minor code quality improvements #335

New issue

Closed

opened 2026-02-26 21:34:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/173
Author: @rudrankriyam
Created: 1/25/2026
Status: ✅ Merged
Merged: 1/25/2026
Merged by: @rudrankriyam

Base: main ← Head: issue-166-minor-cleanups

📝 Commits (1)

cb5f7a1 fix: improve config durations and CLI output

📊 Changes

8 files changed (+181 additions, -47 deletions)

View changed files

📝 cmd/commands_test.go (+1 -0)
📝 cmd/shared.go (+21 -5)
📝 go.mod (+3 -3)
📝 go.sum (+0 -2)
📝 internal/asc/client_core.go (+25 -14)
📝 internal/auth/integration_test.go (+9 -3)
📝 internal/config/config.go (+101 -8)
📝 internal/config/config_test.go (+21 -12)

📄 Description

Summary

skip ANSI styling when the terminal doesn’t support it (NO_COLOR/dumb/TTY)
switch retry logging to slog for structured output
use typed duration values in config while preserving JSON string format
allow bypassing keychain via ASC_BYPASS_KEYCHAIN for deterministic auth tests

Testing

make test
make lint

Fixes #166

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/173 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/25/2026 **Status:** ✅ Merged **Merged:** 1/25/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `issue-166-minor-cleanups` --- ### 📝 Commits (1) - [`cb5f7a1`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/cb5f7a11e14385b98268d5d98d59b0ed60a5e729) fix: improve config durations and CLI output ### 📊 Changes **8 files changed** (+181 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `cmd/commands_test.go` (+1 -0) 📝 `cmd/shared.go` (+21 -5) 📝 `go.mod` (+3 -3) 📝 `go.sum` (+0 -2) 📝 `internal/asc/client_core.go` (+25 -14) 📝 `internal/auth/integration_test.go` (+9 -3) 📝 `internal/config/config.go` (+101 -8) 📝 `internal/config/config_test.go` (+21 -12) </details> ### 📄 Description ## Summary - skip ANSI styling when the terminal doesn’t support it (NO_COLOR/dumb/TTY) - switch retry logging to slog for structured output - use typed duration values in config while preserving JSON string format - allow bypassing keychain via ASC_BYPASS_KEYCHAIN for deterministic auth tests ## Testing - make test - make lint Fixes #166 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>