[PR #128] [MERGED] Unused client pricing functions #309

New issue

Closed

opened 2026-02-26 21:34:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/128
Author: @cursor[bot]
Created: 1/24/2026
Status: ✅ Merged
Merged: 1/24/2026
Merged by: @rudrankriyam

Base: cursor/app-pricing-and-availability-bc84 ← Head: cursor/unused-client-pricing-functions-0ab0

📝 Commits (2)

54fa732 Remove unused pricing client methods
b119bbd Add pricing subcommands for detailed endpoints.

📊 Changes

6 files changed (+441 additions, -80 deletions)

View changed files

📝 cmd/pricing.go (+238 -6)
📝 cmd/pricing_test.go (+65 -0)
📝 internal/asc/client_pricing.go (+18 -18)
📝 internal/asc/output_core.go (+8 -0)
📝 internal/asc/pricing_output.go (+56 -0)
📝 internal/asc/pricing_test.go (+56 -56)

📄 Description

Remove five exported client functions and their tests from the internal/asc package that were identified as unused dead code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/128 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/24/2026 **Status:** ✅ Merged **Merged:** 1/24/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `cursor/app-pricing-and-availability-bc84` ← **Head:** `cursor/unused-client-pricing-functions-0ab0` --- ### 📝 Commits (2) - [`54fa732`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/54fa732ab404fd7c4486f0f76074e7b3496bb5ba) Remove unused pricing client methods - [`b119bbd`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b119bbd4903f3109c8c585e5c19e9849cebf806b) Add pricing subcommands for detailed endpoints. ### 📊 Changes **6 files changed** (+441 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `cmd/pricing.go` (+238 -6) 📝 `cmd/pricing_test.go` (+65 -0) 📝 `internal/asc/client_pricing.go` (+18 -18) 📝 `internal/asc/output_core.go` (+8 -0) 📝 `internal/asc/pricing_output.go` (+56 -0) 📝 `internal/asc/pricing_test.go` (+56 -56) </details> ### 📄 Description Remove five exported client functions and their tests from the `internal/asc` package that were identified as unused dead code. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>