[PR #107] [MERGED] Signing files fetch command #290

New issue

Closed

opened 2026-02-26 21:34:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/107
Author: @rudrankriyam
Created: 1/24/2026
Status: ✅ Merged
Merged: 1/26/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/signing-files-fetch-command-d654

📝 Commits (10+)

5d5cf18 Add signing fetch command and client support
9719ec9 Fix signing profile lookup edge cases
6452af6 Adjust signing fetch validation
dcb5c54 Merge pull request #117 from rudrankriyam/cursor/signing-profile-issues-d0e3
f5974f5 Sanitize fallback filename
14fb16e Merge pull request #125 from rudrankriyam/cursor/filename-sanitizer-fallback-ff6c
ef9f80d Handle tvOS in-house profile inference
d374301 Merge pull request #129 from rudrankriyam/cursor/tvos-inhouse-inference-1435
2c1dfee Merge origin/main into cursor/signing-files-fetch-command-d654
cc5ac03 Merge main (includes PR #106 TestFlight) into signing branch

📊 Changes

13 files changed (+759 additions, -9 deletions)

View changed files

📝 cmd/devices.go (+36 -0)
📝 cmd/root.go (+1 -0)
➕ cmd/signing.go (+31 -0)
➕ cmd/signing_fetch.go (+354 -0)
➕ cmd/signing_fetch_test.go (+109 -0)
📝 internal/asc/client_http_test.go (+52 -0)
📝 internal/asc/client_options.go (+68 -0)
📝 internal/asc/client_queries.go (+8 -0)
📝 internal/asc/devices_output.go (+23 -0)
📝 internal/asc/output_core.go (+8 -0)
📝 internal/asc/signing.go (+15 -8)
➕ internal/asc/signing_fetch.go (+14 -0)
📝 internal/asc/signing_output.go (+40 -1)

📄 Description

Implement asc signing fetch command to automate fetching and managing signing certificates and provisioning profiles.

This command streamlines the process of obtaining necessary signing assets for App Store Connect apps, including the ability to create missing profiles. It integrates with existing bundle ID, certificate, device, and profile client methods, and includes secure file writing to prevent accidental overwrites.

Fixes #86

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/107 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/24/2026 **Status:** ✅ Merged **Merged:** 1/26/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/signing-files-fetch-command-d654` --- ### 📝 Commits (10+) - [`5d5cf18`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/5d5cf18d455fd141de0e224558cb7fdc7365e7d3) Add signing fetch command and client support - [`9719ec9`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/9719ec998c51bb20d3ef8cd2d3711ddecefee71f) Fix signing profile lookup edge cases - [`6452af6`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6452af6bd5ec58dd5190b2af4a6240be71888292) Adjust signing fetch validation - [`dcb5c54`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/dcb5c5433fae218fc66133a1b4926140372b0826) Merge pull request #117 from rudrankriyam/cursor/signing-profile-issues-d0e3 - [`f5974f5`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f5974f5db72d32555792eda8d443334854cd62b8) Sanitize fallback filename - [`14fb16e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/14fb16e2ce138e9937cec6480dc285c5583e1d9e) Merge pull request #125 from rudrankriyam/cursor/filename-sanitizer-fallback-ff6c - [`ef9f80d`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/ef9f80d727344e0cf403b29e85d4a58c9a733891) Handle tvOS in-house profile inference - [`d374301`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d3743017c93286e6c1c6c8fedef932cddc0699d9) Merge pull request #129 from rudrankriyam/cursor/tvos-inhouse-inference-1435 - [`2c1dfee`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/2c1dfee68c891476929f7837aff7eee0f031d998) Merge origin/main into cursor/signing-files-fetch-command-d654 - [`cc5ac03`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/cc5ac032e8f4f5705ffb81ee3d81fd2334a760ad) Merge main (includes PR #106 TestFlight) into signing branch ### 📊 Changes **13 files changed** (+759 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `cmd/devices.go` (+36 -0) 📝 `cmd/root.go` (+1 -0) ➕ `cmd/signing.go` (+31 -0) ➕ `cmd/signing_fetch.go` (+354 -0) ➕ `cmd/signing_fetch_test.go` (+109 -0) 📝 `internal/asc/client_http_test.go` (+52 -0) 📝 `internal/asc/client_options.go` (+68 -0) 📝 `internal/asc/client_queries.go` (+8 -0) 📝 `internal/asc/devices_output.go` (+23 -0) 📝 `internal/asc/output_core.go` (+8 -0) 📝 `internal/asc/signing.go` (+15 -8) ➕ `internal/asc/signing_fetch.go` (+14 -0) 📝 `internal/asc/signing_output.go` (+40 -1) </details> ### 📄 Description Implement `asc signing fetch` command to automate fetching and managing signing certificates and provisioning profiles. This command streamlines the process of obtaining necessary signing assets for App Store Connect apps, including the ability to create missing profiles. It integrates with existing bundle ID, certificate, device, and profile client methods, and includes secure file writing to prevent accidental overwrites. --- <a href="https://cursor.com/background-agent?bcId=bc-f4da6314-2817-47e7-aadc-ab4ced5ccf9a"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a> <a href="https://cursor.com/agents?id=bc-f4da6314-2817-47e7-aadc-ab4ced5ccf9a"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> Fixes #86 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>