[PR #97] [MERGED] Refactor large files and improve localization downloads #281

New issue

Closed

opened 2026-02-26 21:34:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/97
Author: @rudrankriyam
Created: 1/24/2026
Status: ✅ Merged
Merged: 1/24/2026
Merged by: @rudrankriyam

Base: main ← Head: refactor/ai-structure-plan

📝 Commits (10+)

0ee7c5f Split core client and HTTP helpers
52b4da7 Extract shared client types and query helpers
3074af0 Split apps, builds, and versions client code
33214d3 Split output formatting helpers
acf34e1 Split commands into domain files
9a86c14 Split beta and localization commands
aad3f02 Split analytics and sandbox commands
b720111 Merge origin/main
403141a Add pagination to localization downloads
90cc8af Fix beta group update flag handling

📊 Changes

40 files changed (+7888 additions, -7516 deletions)

View changed files

📝 cmd/analytics.go (+0 -605)
➕ cmd/analytics_requests.go (+485 -0)
➕ cmd/analytics_sales.go (+141 -0)
➕ cmd/apps.go (+105 -0)
➕ cmd/beta_groups.go (+472 -0)
➕ cmd/beta_helpers.go (+73 -0)
📝 cmd/beta_testers.go (+0 -524)
➕ cmd/builds_commands.go (+392 -0)
➖ cmd/commands.go (+0 -1147)
➕ cmd/crashes.go (+122 -0)
➕ cmd/feedback.go (+125 -0)
📝 cmd/localizations.go (+0 -433)
➕ cmd/localizations_commands.go (+514 -0)
📝 cmd/localizations_test.go (+77 -0)
➕ cmd/reviews.go (+168 -0)
➕ cmd/root.go (+72 -0)
📝 cmd/sandbox.go (+0 -558)
➕ cmd/sandbox_create.go (+185 -0)
➕ cmd/sandbox_list.go (+104 -0)
➕ cmd/sandbox_manage.go (+302 -0)

...and 20 more files

📄 Description

Summary

Split internal ASC client and cmd logic into domain-focused files to keep files under the size cap.
Move output formatting into dedicated output files and wire new phased release output routing.
Add pagination support to localization downloads and clarify analytics vendor env help text.

Test plan

make build
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/97 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/24/2026 **Status:** ✅ Merged **Merged:** 1/24/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `refactor/ai-structure-plan` --- ### 📝 Commits (10+) - [`0ee7c5f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0ee7c5f3a5e8976f2167b6c201d3fa132feecca9) Split core client and HTTP helpers - [`52b4da7`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/52b4da7f58ac1edeb01a36e0f77315abaef3665d) Extract shared client types and query helpers - [`3074af0`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3074af00899c3ededf200df23f696b90021c274d) Split apps, builds, and versions client code - [`33214d3`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/33214d325a8ab415bf14fe0eb0cf3ff1d68a538d) Split output formatting helpers - [`acf34e1`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/acf34e171b78bf0a798367639a1ab36598cece0d) Split commands into domain files - [`9a86c14`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/9a86c14deaee7aaf4afa03d21d0ce4605b6f92dd) Split beta and localization commands - [`aad3f02`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/aad3f02ab511d9caed571d4910c60ccf5dcd8fe1) Split analytics and sandbox commands - [`b720111`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b720111d0557d4db5ff0f9a7d108f342e9e33945) Merge origin/main - [`403141a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/403141a86970adf72c70be255e404575d346bffa) Add pagination to localization downloads - [`90cc8af`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/90cc8af49d3eb2386ba963db63d260b9e15683c3) Fix beta group update flag handling ### 📊 Changes **40 files changed** (+7888 additions, -7516 deletions) <details> <summary>View changed files</summary> 📝 `cmd/analytics.go` (+0 -605) ➕ `cmd/analytics_requests.go` (+485 -0) ➕ `cmd/analytics_sales.go` (+141 -0) ➕ `cmd/apps.go` (+105 -0) ➕ `cmd/beta_groups.go` (+472 -0) ➕ `cmd/beta_helpers.go` (+73 -0) 📝 `cmd/beta_testers.go` (+0 -524) ➕ `cmd/builds_commands.go` (+392 -0) ➖ `cmd/commands.go` (+0 -1147) ➕ `cmd/crashes.go` (+122 -0) ➕ `cmd/feedback.go` (+125 -0) 📝 `cmd/localizations.go` (+0 -433) ➕ `cmd/localizations_commands.go` (+514 -0) 📝 `cmd/localizations_test.go` (+77 -0) ➕ `cmd/reviews.go` (+168 -0) ➕ `cmd/root.go` (+72 -0) 📝 `cmd/sandbox.go` (+0 -558) ➕ `cmd/sandbox_create.go` (+185 -0) ➕ `cmd/sandbox_list.go` (+104 -0) ➕ `cmd/sandbox_manage.go` (+302 -0) _...and 20 more files_ </details> ### 📄 Description ## Summary - Split internal ASC client and cmd logic into domain-focused files to keep files under the size cap. - Move output formatting into dedicated output files and wire new phased release output routing. - Add pagination support to localization downloads and clarify analytics vendor env help text. ## Test plan - [x] make build - [x] make lint - [x] make test --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>