[PR #80] [MERGED] Legacy keychain fixes #269

New issue

Closed

opened 2026-02-26 21:34:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/80
Author: @cursor[bot]
Created: 1/24/2026
Status: ✅ Merged
Merged: 1/24/2026
Merged by: @rudrankriyam

Base: fix/keychain-default ← Head: cursor/legacy-keychain-fixes-39ad

📝 Commits (2)

8464ad7 Fix legacy keychain migration handling
77a10fb Fix legacy keychain removal error handling.

📊 Changes

2 files changed (+33 additions, -10 deletions)

View changed files

📝 internal/auth/keychain.go (+31 -9)
📝 internal/auth/keychain_test.go (+2 -1)

📄 Description

Fixes issues with legacy keychain credential removal, improves migration test setup, and ensures comprehensive legacy credential migration.

Previously, RemoveCredentials failed to remove legacy-only credentials because it only attempted legacy removal if the new keychain removal succeeded. The test setup for keychain migration used a shared keyring, preventing proper validation of migration logic. Additionally, the migration logic in listFromKeychain was skipped if any credentials were found in the new keychain, potentially leaving legacy credentials orphaned.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/80 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/24/2026 **Status:** ✅ Merged **Merged:** 1/24/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `fix/keychain-default` ← **Head:** `cursor/legacy-keychain-fixes-39ad` --- ### 📝 Commits (2) - [`8464ad7`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8464ad70c0b183c6215b1aa2840995294117f881) Fix legacy keychain migration handling - [`77a10fb`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/77a10fbcb1c642e6fd5d14e7ad773bb54ecbe354) Fix legacy keychain removal error handling. ### 📊 Changes **2 files changed** (+33 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `internal/auth/keychain.go` (+31 -9) 📝 `internal/auth/keychain_test.go` (+2 -1) </details> ### 📄 Description Fixes issues with legacy keychain credential removal, improves migration test setup, and ensures comprehensive legacy credential migration. Previously, `RemoveCredentials` failed to remove legacy-only credentials because it only attempted legacy removal if the new keychain removal succeeded. The test setup for keychain migration used a shared keyring, preventing proper validation of migration logic. Additionally, the migration logic in `listFromKeychain` was skipped if any credentials were found in the new keychain, potentially leaving legacy credentials orphaned. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>