[PR #67] [MERGED] Improve IPA plist parsing and retry observability #265

New issue

Closed

opened 2026-02-26 21:34:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/67
Author: @rudrankriyam
Created: 1/23/2026
Status: ✅ Merged
Merged: 1/24/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/plan-and-build-cleanup-bf1b

📝 Commits (6)

bfba2f9 Add IPA metadata extraction for build uploads
b644b28 Improve rate limit handling for API requests
a3eabe3 Trim plan to remaining work
081ce7b Fix IPA plist decoding
60fad8b Handle numeric IPA plist values
5561ffc Add retry logging toggle and docs

📊 Changes

9 files changed (+410 additions, -394 deletions)

View changed files

📝 PLAN.md (+21 -376)
📝 README.md (+7 -0)
📝 cmd/commands.go (+34 -11)
➕ cmd/ipa.go (+92 -0)
➕ cmd/ipa_test.go (+151 -0)
📝 go.mod (+1 -0)
📝 go.sum (+4 -0)
📝 internal/asc/client.go (+69 -7)
📝 internal/asc/client_http_test.go (+31 -0)

📄 Description

Summary

handle numeric/binary Info.plist values when extracting IPA version/build
add retry attempt logging behind ASC_RETRY_LOG
document retry-related environment variables in README

Test plan

go test ./cmd
make lint
make build
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/67 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/23/2026 **Status:** ✅ Merged **Merged:** 1/24/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/plan-and-build-cleanup-bf1b` --- ### 📝 Commits (6) - [`bfba2f9`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/bfba2f9a7802fe4c20d6689ead600b2268e76c56) Add IPA metadata extraction for build uploads - [`b644b28`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b644b289573c3efda7fc034beb772f737b25d217) Improve rate limit handling for API requests - [`a3eabe3`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a3eabe3f5009fd6dccdc5b64619ffaef763bac2a) Trim plan to remaining work - [`081ce7b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/081ce7b7de00f16e6c760ea9d03fa0919e04f244) Fix IPA plist decoding - [`60fad8b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/60fad8b29863d4d530a5edf9bda5cac95b9a1c97) Handle numeric IPA plist values - [`5561ffc`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/5561ffcce4cfa1c7f34987bc6ad3fe4743e203c5) Add retry logging toggle and docs ### 📊 Changes **9 files changed** (+410 additions, -394 deletions) <details> <summary>View changed files</summary> 📝 `PLAN.md` (+21 -376) 📝 `README.md` (+7 -0) 📝 `cmd/commands.go` (+34 -11) ➕ `cmd/ipa.go` (+92 -0) ➕ `cmd/ipa_test.go` (+151 -0) 📝 `go.mod` (+1 -0) 📝 `go.sum` (+4 -0) 📝 `internal/asc/client.go` (+69 -7) 📝 `internal/asc/client_http_test.go` (+31 -0) </details> ### 📄 Description ## Summary - handle numeric/binary `Info.plist` values when extracting IPA version/build - add retry attempt logging behind `ASC_RETRY_LOG` - document retry-related environment variables in README ## Test plan - `go test ./cmd` - `make lint` - `make build` - `make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>