[PR #62] [MERGED] Code duplication cleanup #260

New issue

Closed

opened 2026-02-26 21:34:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/62
Author: @cursor[bot]
Created: 1/23/2026
Status: ✅ Merged
Merged: 1/23/2026
Merged by: @rudrankriyam

Base: cursor/beta-group-tester-management-3a13 ← Head: cursor/code-duplication-cleanup-cc75

📝 Commits (10+)

028215d Merge pull request #55 from rudrankriyam/cursor/beta-group-tester-management-3a13
a078df7 Add beta testers get and build filter
a31722d Add beta tester get and build filter tests
3935c22 fix: only use one relationship filter for beta testers
a1be0dc Merge pull request #56 from rudrankriyam/cursor/beta-tester-details-build-filter-7ed4
f268343 Add beta tester group membership commands
bf9a093 Merge pull request #57 from rudrankriyam/cursor/tester-group-relationships-fe64
76e82a5 Add build beta group management
84bce5b Merge pull request #58 from rudrankriyam/cursor/builds-beta-group-management-9c21
180d2cb Add pre-release versions list and get

📊 Changes

11 files changed (+2451 additions, -44 deletions)

View changed files

📝 cmd/beta.go (+179 -12)
➕ cmd/build_localizations.go (+391 -0)
➕ cmd/builds.go (+127 -0)
📝 cmd/commands.go (+8 -1)
📝 cmd/commands_test.go (+243 -2)
➕ cmd/prerelease.go (+173 -0)
➕ cmd/testflight.go (+195 -0)
📝 internal/asc/client.go (+574 -28)
📝 internal/asc/client_http_test.go (+365 -1)
📝 internal/asc/client_test.go (+41 -0)
📝 internal/asc/output_test.go (+155 -0)

📄 Description

Refactor to remove duplicate struct definitions and reuse existing CSV parsing utility.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/62 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/23/2026 **Status:** ✅ Merged **Merged:** 1/23/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `cursor/beta-group-tester-management-3a13` ← **Head:** `cursor/code-duplication-cleanup-cc75` --- ### 📝 Commits (10+) - [`028215d`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/028215db9ce86b2fda19138c83a35730ea9ae6ab) Merge pull request #55 from rudrankriyam/cursor/beta-group-tester-management-3a13 - [`a078df7`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a078df7932b5cb61e521084ff14a5c8cccfea708) Add beta testers get and build filter - [`a31722d`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a31722d54df55586004d13ae485b2eb32b6f31b8) Add beta tester get and build filter tests - [`3935c22`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3935c2294078ab4648d7729223f48c6f93a3f71c) fix: only use one relationship filter for beta testers - [`a1be0dc`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a1be0dc855d6d61d7ed60a77baa3715c908db8d4) Merge pull request #56 from rudrankriyam/cursor/beta-tester-details-build-filter-7ed4 - [`f268343`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/f268343d3afee5df8bcc65175d3a6b0657774f3a) Add beta tester group membership commands - [`bf9a093`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/bf9a0935d84dd15d17a6c997e2523d547f860ca6) Merge pull request #57 from rudrankriyam/cursor/tester-group-relationships-fe64 - [`76e82a5`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/76e82a570f77ea62a396ea6e48f1aeb2eaed2eed) Add build beta group management - [`84bce5b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/84bce5b01aff60896a6ee14b887c93d77556d7ea) Merge pull request #58 from rudrankriyam/cursor/builds-beta-group-management-9c21 - [`180d2cb`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/180d2cb6613fbb433517bd37b2cd023553a8a4de) Add pre-release versions list and get ### 📊 Changes **11 files changed** (+2451 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `cmd/beta.go` (+179 -12) ➕ `cmd/build_localizations.go` (+391 -0) ➕ `cmd/builds.go` (+127 -0) 📝 `cmd/commands.go` (+8 -1) 📝 `cmd/commands_test.go` (+243 -2) ➕ `cmd/prerelease.go` (+173 -0) ➕ `cmd/testflight.go` (+195 -0) 📝 `internal/asc/client.go` (+574 -28) 📝 `internal/asc/client_http_test.go` (+365 -1) 📝 `internal/asc/client_test.go` (+41 -0) 📝 `internal/asc/output_test.go` (+155 -0) </details> ### 📄 Description Refactor to remove duplicate struct definitions and reuse existing CSV parsing utility. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>