[PR #37] [MERGED] Trim whitespace in sandbox password validation #246

New issue

Closed

opened 2026-02-26 21:34:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/37
Author: @rudrankriyam
Created: 1/21/2026
Status: ✅ Merged
Merged: 1/21/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/password-validation-whitespace-7c80

📝 Commits (3)

d25771c Trim sandbox password before validation
a8b9bf4 Merge remote-tracking branch 'origin/main' into cursor/password-validation-whitespace-7c80
d97276a Cover trimmed whitespace in sandbox password validation

📊 Changes

2 files changed (+4 additions, -2 deletions)

View changed files

📝 cmd/sandbox_helpers.go (+3 -2)
📝 cmd/sandbox_helpers_test.go (+1 -0)

📄 Description

Summary

trim leading/trailing whitespace before sandbox password validation checks
add test coverage for whitespace-trimmed passwords

Test plan

make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/37 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/21/2026 **Status:** ✅ Merged **Merged:** 1/21/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/password-validation-whitespace-7c80` --- ### 📝 Commits (3) - [`d25771c`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d25771cdf96064b45f83faa3662d6cbd1face493) Trim sandbox password before validation - [`a8b9bf4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a8b9bf4d179e3f8136e06debf63d8884ac7a9073) Merge remote-tracking branch 'origin/main' into cursor/password-validation-whitespace-7c80 - [`d97276a`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d97276ae3a8dc494dbf46b4a2248e44455369399) Cover trimmed whitespace in sandbox password validation ### 📊 Changes **2 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `cmd/sandbox_helpers.go` (+3 -2) 📝 `cmd/sandbox_helpers_test.go` (+1 -0) </details> ### 📄 Description ## Summary - trim leading/trailing whitespace before sandbox password validation checks - add test coverage for whitespace-trimmed passwords ## Test plan - [x] `make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>