[PR #31] [MERGED] Handle missing submission lookups #239

New issue

Closed

opened 2026-02-26 21:34:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/31
Author: @rudrankriyam
Created: 1/21/2026
Status: ✅ Merged
Merged: 1/21/2026
Merged by: @rudrankriyam

Base: main ← Head: feature/manual-qa-fixes

📝 Commits (1)

3f3cbff Handle missing submission lookups

📊 Changes

5 files changed (+143 additions, -6 deletions)

View changed files

📝 cmd/submit.go (+12 -0)
📝 cmd/versions.go (+31 -5)
➕ cmd/versions_test.go (+90 -0)
📝 internal/asc/client.go (+7 -1)
📝 internal/asc/client_http_test.go (+3 -0)

📄 Description

Summary

Treat missing build/submission relationships as optional in versions get includes
Improve submit status/cancel not-found messaging and make not-found detection more robust
Add unit coverage for optional fetch helpers and not-found detection

Test plan

PATH="$(go env GOPATH)/bin:$PATH" make format
go test ./...
make clean build
./asc versions get --version-id <VERSION_ID> --include-submission
./asc submit status --version-id <VERSION_ID>

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/31 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/21/2026 **Status:** ✅ Merged **Merged:** 1/21/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feature/manual-qa-fixes` --- ### 📝 Commits (1) - [`3f3cbff`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3f3cbffb3375004b251abeb3608e9b1b278fd981) Handle missing submission lookups ### 📊 Changes **5 files changed** (+143 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `cmd/submit.go` (+12 -0) 📝 `cmd/versions.go` (+31 -5) ➕ `cmd/versions_test.go` (+90 -0) 📝 `internal/asc/client.go` (+7 -1) 📝 `internal/asc/client_http_test.go` (+3 -0) </details> ### 📄 Description ## Summary - Treat missing build/submission relationships as optional in `versions get` includes - Improve submit status/cancel not-found messaging and make not-found detection more robust - Add unit coverage for optional fetch helpers and not-found detection ## Test plan - `PATH="$(go env GOPATH)/bin:$PATH" make format` - `go test ./...` - `make clean build` - `./asc versions get --version-id <VERSION_ID> --include-submission` - `./asc submit status --version-id <VERSION_ID>` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>