[PR #29] [MERGED] Block comment termination #238

New issue

Closed

opened 2026-02-26 21:34:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/29
Author: @cursor[bot]
Created: 1/21/2026
Status: ✅ Merged
Merged: 1/21/2026
Merged by: @rudrankriyam

Base: feature/localizations ← Head: cursor/block-comment-termination-11f7

📝 Commits (1)

425e315 Fix block comment EOF handling

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 cmd/localizations.go (+3 -1)

📄 Description

Fix skipWhitespaceAndComments to correctly handle block comments at EOF.

Previously, block comments at the very end of a file were incorrectly reported as unterminated because the eof() check after the loop didn't distinguish between finding */ and then reaching EOF, versus never finding */ before EOF.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/29 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/21/2026 **Status:** ✅ Merged **Merged:** 1/21/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `feature/localizations` ← **Head:** `cursor/block-comment-termination-11f7` --- ### 📝 Commits (1) - [`425e315`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/425e315b8dbb0f318dc005e4a777a0e27ef6d0fc) Fix block comment EOF handling ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `cmd/localizations.go` (+3 -1) </details> ### 📄 Description Fix `skipWhitespaceAndComments` to correctly handle block comments at EOF. Previously, block comments at the very end of a file were incorrectly reported as unterminated because the `eof()` check after the loop didn't distinguish between finding `*/` and then reaching EOF, versus never finding `*/` before EOF. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>