[PR #6] [CLOSED] Workflow integration tests #220

Closed
opened 2026-02-26 21:34:11 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/6
Author: @cursor[bot]
Created: 1/20/2026
Status: Closed

Base: feature/pagination-filters-integration-testsHead: cursor/workflow-integration-tests-f5b9


📝 Commits (1)

  • 0fec8e8 Fix integration tests workflow: add build tag and proper key file handling

📊 Changes

1 file changed (+9 additions, -2 deletions)

View changed files

📝 .github/workflows/main-branch.yml (+9 -2)

📄 Description

Fix integration tests in main branch workflow by adding build tag and correctly handling private key secret.

The go test command was missing the -tags=integration flag, which prevented any integration tests from executing. Additionally, the ASC_PRIVATE_KEY_PATH environment variable was attempting to use a GitHub secret directly as a file path, which is not supported; the secret content now gets written to a temporary file first.



🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/6 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/20/2026 **Status:** ❌ Closed **Base:** `feature/pagination-filters-integration-tests` ← **Head:** `cursor/workflow-integration-tests-f5b9` --- ### 📝 Commits (1) - [`0fec8e8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/0fec8e818787057c6a34e1e15dbac46c7566e589) Fix integration tests workflow: add build tag and proper key file handling ### 📊 Changes **1 file changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/main-branch.yml` (+9 -2) </details> ### 📄 Description Fix integration tests in main branch workflow by adding build tag and correctly handling private key secret. The `go test` command was missing the `-tags=integration` flag, which prevented any integration tests from executing. Additionally, the `ASC_PRIVATE_KEY_PATH` environment variable was attempting to use a GitHub secret directly as a file path, which is not supported; the secret content now gets written to a temporary file first. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 21:34:11 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/App-Store-Connect-CLI#220
No description provided.