[PR #1] [MERGED] Add pagination, filters, and integration tests #215

New issue

Closed

opened 2026-02-26 21:34:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/1
Author: @rudrankriyam
Created: 1/20/2026
Status: ✅ Merged
Merged: 1/20/2026
Merged by: @rudrankriyam

Base: main ← Head: feature/pagination-filters-integration-tests

📝 Commits (7)

a38fa73 Add pagination/filter flags and opt-in integration tests.
9286cf9 Add Codemagic CI/CD configuration
7757a5d Rename CLAUDE.md to Agents.md with redirect
10854e4 Add Codemagic workflows for PR checks and main branch
db6cfbd Expand integration test coverage.
c8092fc Add platform/build/tester filters and sort checks.
77f6b59 Add apps/builds list commands and output formats.

📊 Changes

13 files changed (+1866 additions, -290 deletions)

View changed files

➖ .github/workflows/release.yml (+0 -58)
➖ .github/workflows/test.yml (+0 -29)
➕ Agents.md (+160 -0)
📝 CLAUDE.md (+1 -160)
📝 CONTRIBUTING.md (+14 -0)
📝 Makefile (+7 -0)
📝 PLAN.md (+12 -13)
📝 README.md (+18 -0)
📝 cmd/commands.go (+306 -8)
➕ codemagic.yaml (+147 -0)
📝 internal/asc/client.go (+555 -22)
📝 internal/asc/client_test.go (+148 -0)
➕ internal/asc/integration_test.go (+498 -0)

📄 Description

Summary

add pagination flags and ASC next URL support
add feedback/crash filters for device model and OS version
add opt-in integration tests and remove GitHub Actions workflows

Test plan

go test ./...
go test -tags=integration ./internal/asc -run Integration (requires ASC_* env vars)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/1 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/20/2026 **Status:** ✅ Merged **Merged:** 1/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feature/pagination-filters-integration-tests` --- ### 📝 Commits (7) - [`a38fa73`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a38fa73c6946bdb2f76d2f4b1c8b0e9087b557d3) Add pagination/filter flags and opt-in integration tests. - [`9286cf9`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/9286cf905663683c43ebb11e87cea6bfe95673ac) Add Codemagic CI/CD configuration - [`7757a5d`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/7757a5d3719461131a3809056a0372d8ef475e6c) Rename CLAUDE.md to Agents.md with redirect - [`10854e4`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/10854e47b7250e44e0b55c9d425192baabf089dd) Add Codemagic workflows for PR checks and main branch - [`db6cfbd`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/db6cfbdd928b476dbae11ae6fb42f4a5ecf2a0bb) Expand integration test coverage. - [`c8092fc`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/c8092fcaeee2772d9699a8fe9a7311afbfed4502) Add platform/build/tester filters and sort checks. - [`77f6b59`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/77f6b594cf621ae2f4340a69359874b60eb191b1) Add apps/builds list commands and output formats. ### 📊 Changes **13 files changed** (+1866 additions, -290 deletions) <details> <summary>View changed files</summary> ➖ `.github/workflows/release.yml` (+0 -58) ➖ `.github/workflows/test.yml` (+0 -29) ➕ `Agents.md` (+160 -0) 📝 `CLAUDE.md` (+1 -160) 📝 `CONTRIBUTING.md` (+14 -0) 📝 `Makefile` (+7 -0) 📝 `PLAN.md` (+12 -13) 📝 `README.md` (+18 -0) 📝 `cmd/commands.go` (+306 -8) ➕ `codemagic.yaml` (+147 -0) 📝 `internal/asc/client.go` (+555 -22) 📝 `internal/asc/client_test.go` (+148 -0) ➕ `internal/asc/integration_test.go` (+498 -0) </details> ### 📄 Description ## Summary - add pagination flags and ASC next URL support - add feedback/crash filters for device model and OS version - add opt-in integration tests and remove GitHub Actions workflows ## Test plan - [x] `go test ./...` - [ ] `go test -tags=integration ./internal/asc -run Integration` (requires `ASC_*` env vars) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>