starred/App-Store-Connect-CLI
1
0
Fork 0
mirror of https://github.com/rudrankriyam/App-Store-Connect-CLI.git synced 2026-04-25 23:55:51 +03:00
Code Issues 2 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #470] Parity: IAP offer code generation endpoints (custom codes + one-time use batches) #135

New issue
Closed
opened 2026-02-26 21:33:41 +03:00 by kerem · 3 comments
kerem commented 2026-02-26 21:33:41 +03:00
Owner
Copy link

Originally created by @rudrankriyam on GitHub (Feb 10, 2026).
Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/470

Overview

Add missing creation/generation operations for in-app purchase offer code code resources.

Scope (OpenAPI resources)

  • POST /v1/inAppPurchaseOfferCodeCustomCodes
  • POST /v1/inAppPurchaseOfferCodeOneTimeUseCodes

Current state

Current CLI support already includes read/update surfaces for these resources (list/get, and patch where applicable), but create/generate endpoints are not exposed.

Proposed CLI

Custom (vanity) codes

  • asc iap offer-codes custom-codes create --offer-code-id "OFFER_CODE_ID" --custom-code "HOLIDAY2026"

One-time use code batches

  • asc iap offer-codes one-time-codes create --offer-code-id "OFFER_CODE_ID" --quantity 100 --expiration-date "2026-12-31"

Examples:

  • asc iap offer-codes custom-codes create --offer-code-id "OFFER_CODE_ID" --custom-code "SUMMER26"
  • asc iap offer-codes one-time-codes create --offer-code-id "OFFER_CODE_ID" --quantity 500 --expiration-date "2026-09-30"

Flag patterns

Common: --offer-code-id, --output, --pretty

Additional:

  • custom codes: --custom-code
  • one-time batches: --quantity, --expiration-date (or exact OpenAPI-required field names)

Validation rules:

  • required IDs + required create attributes
  • quantity positive integer
  • expiration date format validation

Detailed TODO

  • Add request/attribute types for both create endpoints in internal/asc IAP offer code types.
  • Add client methods in internal/asc/client_iap_subresources.go:
    • create custom code
    • create one-time use code batch
  • Add CLI subcommands in internal/cli/iap/offer_code_codes.go:
    • custom-codes create
    • one-time-codes create
  • Wire help text/examples and keep command naming aligned with existing offer-code groups.

Acceptance criteria

  • Custom IAP offer code creation works via CLI.
  • One-time use batch generation works via CLI.
  • Responses print correctly in default JSON and optional table/markdown outputs.
  • make format, make lint, and make test pass.

Tests

  • HTTP client tests for both POST endpoints with payload assertions.
  • cmdtests for required flags and invalid values.
  • cmdtests for successful create flows and output behavior.

Implementation notes

  • Keep this consistent with existing subscription offer code command patterns where possible.
  • Maintain explicit flags and non-interactive behavior.

References

  • docs/openapi/paths.txt
  • docs/openapi/latest.json
  • internal/asc/client_iap_subresources.go
  • internal/cli/iap/offer_code_codes.go
Originally created by @rudrankriyam on GitHub (Feb 10, 2026). Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/470 # Overview Add missing creation/generation operations for in-app purchase offer code code resources. # Scope (OpenAPI resources) - `POST /v1/inAppPurchaseOfferCodeCustomCodes` - `POST /v1/inAppPurchaseOfferCodeOneTimeUseCodes` # Current state Current CLI support already includes read/update surfaces for these resources (list/get, and patch where applicable), but create/generate endpoints are not exposed. # Proposed CLI ## Custom (vanity) codes - `asc iap offer-codes custom-codes create --offer-code-id "OFFER_CODE_ID" --custom-code "HOLIDAY2026"` ## One-time use code batches - `asc iap offer-codes one-time-codes create --offer-code-id "OFFER_CODE_ID" --quantity 100 --expiration-date "2026-12-31"` Examples: - `asc iap offer-codes custom-codes create --offer-code-id "OFFER_CODE_ID" --custom-code "SUMMER26"` - `asc iap offer-codes one-time-codes create --offer-code-id "OFFER_CODE_ID" --quantity 500 --expiration-date "2026-09-30"` # Flag patterns Common: `--offer-code-id`, `--output`, `--pretty` Additional: - custom codes: `--custom-code` - one-time batches: `--quantity`, `--expiration-date` (or exact OpenAPI-required field names) Validation rules: - required IDs + required create attributes - `quantity` positive integer - expiration date format validation # Detailed TODO - [ ] Add request/attribute types for both create endpoints in `internal/asc` IAP offer code types. - [ ] Add client methods in `internal/asc/client_iap_subresources.go`: - [ ] create custom code - [ ] create one-time use code batch - [ ] Add CLI subcommands in `internal/cli/iap/offer_code_codes.go`: - [ ] `custom-codes create` - [ ] `one-time-codes create` - [ ] Wire help text/examples and keep command naming aligned with existing offer-code groups. # Acceptance criteria - [ ] Custom IAP offer code creation works via CLI. - [ ] One-time use batch generation works via CLI. - [ ] Responses print correctly in default JSON and optional table/markdown outputs. - [ ] `make format`, `make lint`, and `make test` pass. # Tests - [ ] HTTP client tests for both POST endpoints with payload assertions. - [ ] cmdtests for required flags and invalid values. - [ ] cmdtests for successful create flows and output behavior. # Implementation notes - Keep this consistent with existing subscription offer code command patterns where possible. - Maintain explicit flags and non-interactive behavior. # References - `docs/openapi/paths.txt` - `docs/openapi/latest.json` - `internal/asc/client_iap_subresources.go` - `internal/cli/iap/offer_code_codes.go`
kerem closed this issue 2026-02-26 21:33:41 +03:00
kerem commented 2026-02-26 21:33:42 +03:00
Author
Owner
Copy link

@rudrankriyam commented on GitHub (Feb 10, 2026):

@cursor Please implement this issue end-to-end.

What to build

Add creation/generation support for IAP offer-code code resources.

Endpoints to add

  • POST /v1/inAppPurchaseOfferCodeCustomCodes
  • POST /v1/inAppPurchaseOfferCodeOneTimeUseCodes

Implementation plan

  1. Types (internal/asc)
  • Add create request/attributes for:
    • IAP offer code custom code
    • IAP offer code one-time use code batch
  • Include required relationships to inAppPurchaseOfferCodes.
  1. Client methods (internal/asc/client_iap_subresources.go)
  • CreateInAppPurchaseOfferCodeCustomCode(...)
  • CreateInAppPurchaseOfferCodeOneTimeUseCode(...)
  • Use exact POST routes above and return parsed response objects.
  1. CLI subcommands (internal/cli/iap/offer_code_codes.go)
  • Add:
    • asc iap offer-codes custom-codes create --offer-code-id ... --custom-code ...
    • asc iap offer-codes one-time-codes create --offer-code-id ... --quantity ... --expiration-date ...
  • Validation:
    • required --offer-code-id
    • custom-codes create requires --custom-code
    • one-time-codes create requires positive --quantity
    • validate expiration date format before request
  • Keep output/pretty flags aligned with existing commands.
  1. Help/examples
  • Update long help examples in the custom-codes and one-time-codes groups.

New tests to write

A) Client HTTP tests (internal/asc/client_http_test.go)

  • TestCreateInAppPurchaseOfferCodeCustomCode_UsesPostPath
  • TestCreateInAppPurchaseOfferCodeOneTimeUseCode_UsesPostPath

For each test assert:

  • HTTP method POST
  • exact route path
  • request body type + relationships + required attrs

B) CLI cmdtests (new file)

  • internal/cli/cmdtest/iap_offer_code_code_generation_test.go

Cases to include:

  • custom-codes create missing --offer-code-id -> usage error
  • custom-codes create missing --custom-code -> usage error
  • one-time-codes create missing --offer-code-id -> usage error
  • one-time-codes create invalid --quantity (0, negative, non-integer) -> usage error
  • one-time-codes create invalid --expiration-date -> usage error
  • success create custom code
  • success create one-time batch

C) Output behavior test

  • Ensure success responses render correctly with default JSON and --pretty.

How to test locally

Run exactly:

  • make format
  • make lint
  • make test

Targeted tests:

  • go test ./internal/asc -run 'CreateInAppPurchaseOfferCode(CustomCode|OneTimeUseCode)'
  • go test ./internal/cli/cmdtest -run 'iap_offer_code_code_generation'

Done criteria

  • Both POST endpoints are accessible via CLI create commands.
  • Validation and payload structure are covered by tests.
  • All checks pass (format, lint, test).
<!-- gh-comment-id:3877922551 --> @rudrankriyam commented on GitHub (Feb 10, 2026): @cursor Please implement this issue end-to-end. ## What to build Add creation/generation support for IAP offer-code code resources. ### Endpoints to add - `POST /v1/inAppPurchaseOfferCodeCustomCodes` - `POST /v1/inAppPurchaseOfferCodeOneTimeUseCodes` ## Implementation plan 1. **Types (`internal/asc`)** - Add create request/attributes for: - IAP offer code custom code - IAP offer code one-time use code batch - Include required relationships to `inAppPurchaseOfferCodes`. 2. **Client methods (`internal/asc/client_iap_subresources.go`)** - `CreateInAppPurchaseOfferCodeCustomCode(...)` - `CreateInAppPurchaseOfferCodeOneTimeUseCode(...)` - Use exact POST routes above and return parsed response objects. 3. **CLI subcommands (`internal/cli/iap/offer_code_codes.go`)** - Add: - `asc iap offer-codes custom-codes create --offer-code-id ... --custom-code ...` - `asc iap offer-codes one-time-codes create --offer-code-id ... --quantity ... --expiration-date ...` - Validation: - required `--offer-code-id` - custom-codes create requires `--custom-code` - one-time-codes create requires positive `--quantity` - validate expiration date format before request - Keep output/pretty flags aligned with existing commands. 4. **Help/examples** - Update long help examples in the custom-codes and one-time-codes groups. ## New tests to write ### A) Client HTTP tests (`internal/asc/client_http_test.go`) - `TestCreateInAppPurchaseOfferCodeCustomCode_UsesPostPath` - `TestCreateInAppPurchaseOfferCodeOneTimeUseCode_UsesPostPath` For each test assert: - HTTP method POST - exact route path - request body type + relationships + required attrs ### B) CLI cmdtests (new file) - `internal/cli/cmdtest/iap_offer_code_code_generation_test.go` Cases to include: - custom-codes create missing `--offer-code-id` -> usage error - custom-codes create missing `--custom-code` -> usage error - one-time-codes create missing `--offer-code-id` -> usage error - one-time-codes create invalid `--quantity` (`0`, negative, non-integer) -> usage error - one-time-codes create invalid `--expiration-date` -> usage error - success create custom code - success create one-time batch ### C) Output behavior test - Ensure success responses render correctly with default JSON and `--pretty`. ## How to test locally Run exactly: - `make format` - `make lint` - `make test` Targeted tests: - `go test ./internal/asc -run 'CreateInAppPurchaseOfferCode(CustomCode|OneTimeUseCode)'` - `go test ./internal/cli/cmdtest -run 'iap_offer_code_code_generation'` ## Done criteria - Both POST endpoints are accessible via CLI create commands. - Validation and payload structure are covered by tests. - All checks pass (`format`, `lint`, `test`).
kerem commented 2026-02-26 21:33:42 +03:00
Author
Owner
Copy link

@cursor[bot] commented on GitHub (Feb 10, 2026):

Here's a summary of what I implemented:

Types (internal/asc/iap_resources.go)

  • Added InAppPurchaseOfferCodeCustomCodeCreateRequest with attributes (customCode, numberOfCodes, optional expirationDate) and relationship to inAppPurchaseOfferCodes
  • Added InAppPurchaseOfferCodeOneTimeUseCodeCreateRequest with attributes (numberOfCodes, expirationDate) and relationship to inAppPurchaseOfferCodes

Client methods (internal/asc/client_iap_subresources.go)

  • CreateInAppPurchaseOfferCodeCustomCode -- POST to /v1/inAppPurchaseOfferCodeCustomCodes
  • CreateInAppPurchaseOfferCodeOneTimeUseCode -- POST to /v1/inAppPurchaseOfferCodeOneTimeUseCodes

CLI subcommands (internal/cli/iap/offer_code_codes.go)

  • asc iap offer-codes custom-codes create --offer-code-id ... --custom-code ... --quantity ... [--expiration-date ...] [--output ...] [--pretty]
  • asc iap offer-codes one-time-codes create --offer-code-id ... --quantity ... --expiration-date ... [--output ...] [--pretty]
  • Validation: required flags, positive quantity, date format validation
  • Help text and examples updated for both command groups

Tests

  • 2 client HTTP tests asserting POST method, exact paths, payload types, relationships, and attributes
  • 12 CLI cmdtests covering: missing required flags, invalid quantity (zero/negative), invalid/missing expiration date, successful create flows with JSON output parsing, and pretty-print JSON output
  • All tests pass: make format, make lint, make test all green

View PR

Open in Cursor Open in Web

<!-- gh-comment-id:3877923144 --> @cursor[bot] commented on GitHub (Feb 10, 2026): Here's a summary of what I implemented: **Types (`internal/asc/iap_resources.go`)** - Added `InAppPurchaseOfferCodeCustomCodeCreateRequest` with attributes (`customCode`, `numberOfCodes`, optional `expirationDate`) and relationship to `inAppPurchaseOfferCodes` - Added `InAppPurchaseOfferCodeOneTimeUseCodeCreateRequest` with attributes (`numberOfCodes`, `expirationDate`) and relationship to `inAppPurchaseOfferCodes` **Client methods (`internal/asc/client_iap_subresources.go`)** - `CreateInAppPurchaseOfferCodeCustomCode` -- POST to `/v1/inAppPurchaseOfferCodeCustomCodes` - `CreateInAppPurchaseOfferCodeOneTimeUseCode` -- POST to `/v1/inAppPurchaseOfferCodeOneTimeUseCodes` **CLI subcommands (`internal/cli/iap/offer_code_codes.go`)** - `asc iap offer-codes custom-codes create --offer-code-id ... --custom-code ... --quantity ... [--expiration-date ...] [--output ...] [--pretty]` - `asc iap offer-codes one-time-codes create --offer-code-id ... --quantity ... --expiration-date ... [--output ...] [--pretty]` - Validation: required flags, positive quantity, date format validation - Help text and examples updated for both command groups **Tests** - 2 client HTTP tests asserting POST method, exact paths, payload types, relationships, and attributes - 12 CLI cmdtests covering: missing required flags, invalid quantity (zero/negative), invalid/missing expiration date, successful create flows with JSON output parsing, and pretty-print JSON output - All tests pass: `make format`, `make lint`, `make test` all green <p><a href="https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/472"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/view-pr-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/view-pr-light.png"><img alt="View PR" width="86" height="28" src="https://cursor.com/assets/images/view-pr-light.png"></picture></a></p> <p><a href="https://cursor.com/background-agent?bcId=bc-bf2d7232-0e1a-44ba-9aad-22e9d1c2f577"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-bf2d7232-0e1a-44ba-9aad-22e9d1c2f577"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p>
kerem commented 2026-02-26 21:33:42 +03:00
Author
Owner
Copy link

@rudrankriyam commented on GitHub (Feb 10, 2026):

Implemented and merged in #472.
IAP offer code generation parity is now covered (custom codes plus one-time use batches), including validation and API error-path tests.
Closing as complete.

<!-- gh-comment-id:3878644947 --> @rudrankriyam commented on GitHub (Feb 10, 2026): Implemented and merged in #472. IAP offer code generation parity is now covered (custom codes plus one-time use batches), including validation and API error-path tests. Closing as complete.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.1
1.1.0
1.0.1
1.0.0
0.49.1
0.49.0
0.48.1
0.48.0
0.47.1
0.47.0
0.46.2
0.46.1
0.46.0
0.45.4
0.45.3
0.45.2
0.45.1
0.45.0
0.44.2
0.44.1
0.44.0
0.43.0
0.42.0
0.41.4
0.41.3
0.41.2
0.41.1
0.41.0
0.40.1
0.40.0
0.39.1
0.39.0
0.38.3
0.38.2
0.38.1
0.38.0
0.37.3
0.37.2
0.37.1
0.37.0
0.36.3
0.36.2
0.36.1
0.36.0
0.35.3
0.35.2
0.35.1
0.35.0
0.34.1
0.34.0
0.33.2
0.33.1
0.33.0
0.32.0
0.31.3
0.31.2
0.31.1
0.31.0
0.30.0
0.29.3
0.29.2
0.29.1
0.29.0
0.28.14
0.28.13
0.28.12
0.28.11
0.28.10
0.28.9
0.28.8
0.28.7
0.28.6
0.28.5
0.28.4
0.28.3
0.28.2
0.28.1
0.28.0
0.27.0
0.26.4
0.26.3
0.26.2
0.26.1
0.26.0
0.25.4
0.25.3
0.25.1
0.25.0
0.24.3
0.24.2
0.24.1
0.24.0
0.23.5
0.23.4
0.23.3
0.23.2
0.23.1
0.23.0
0.22.1
0.22.0
0.21.0
0.20.2
0.20.1
0.20.0
0.19.3
0.19.2
0.19.1
0.19.0
0.18.2
0.18.1
0.18.0
0.17.0
0.16.0
0.15.0
0.14.0
0.13.0
0.12.4
0.12.3
0.12.2
0.12.1
0.12.0
0.11.0
0.10.2
0.10.1
0.10.0
0.9.0
0.8.1
0.8.0
0.7.0
0.6.0
0.5.0
0.3.1
0.3.0
0.2.0
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
Labels
Clear labels   
bug

   
bug

   
documentation

   
enhancement

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
bug
documentation
enhancement
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/App-Store-Connect-CLI#135
No description provided.