starred/App-Store-Connect-CLI
1
0
Fork 0
mirror of https://github.com/rudrankriyam/App-Store-Connect-CLI.git synced 2026-04-25 07:35:48 +03:00
Code Issues 2 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #414] Parity: Certificate activation toggle (PATCH) #118

New issue
Closed
opened 2026-02-26 21:33:33 +03:00 by kerem · 3 comments
kerem commented 2026-02-26 21:33:33 +03:00
Owner
Copy link

Originally created by @rudrankriyam on GitHub (Feb 2, 2026).
Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/414

Overview

Add the ability to update certificate activation status.

Scope (OpenAPI resources)

  • PATCH /v1/certificates/{id} - updates activated boolean field

Proposed CLI

  • asc certificates update --id "CERT_ID" --activated true
  • asc certificates update --id "CERT_ID" --activated false

Examples:

  • asc certificates update --id "CERT_ID" --activated true
  • asc certificates update --id "CERT_ID" --activated false

Flag patterns

Common: --id, --activated, --output, --pretty

Output

  • JSON minified by default
  • --pretty for JSON

Detailed TODO

  • Add client method UpdateCertificate in internal/asc/client_signing.go
  • Add certificates update subcommand
  • Add HTTP client tests (mocked)
  • Add CLI cmdtests for flag validation

Acceptance criteria

  • Certificate activation status can be toggled via CLI

Tests

  • Flag validation tests
  • HTTP client test for PATCH endpoint

Implementation notes

  • The only updatable field is activated (boolean)
  • Follow existing patterns in internal/asc/client_signing.go

References

  • docs/openapi/paths.txt
  • docs/openapi/latest.json
  • internal/asc/client_signing.go
Originally created by @rudrankriyam on GitHub (Feb 2, 2026). Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/414 # Overview Add the ability to update certificate activation status. # Scope (OpenAPI resources) - `PATCH /v1/certificates/{id}` - updates `activated` boolean field # Proposed CLI - `asc certificates update --id "CERT_ID" --activated true` - `asc certificates update --id "CERT_ID" --activated false` Examples: - `asc certificates update --id "CERT_ID" --activated true` - `asc certificates update --id "CERT_ID" --activated false` # Flag patterns Common: `--id`, `--activated`, `--output`, `--pretty` # Output - JSON minified by default - `--pretty` for JSON # Detailed TODO - [ ] Add client method `UpdateCertificate` in `internal/asc/client_signing.go` - [ ] Add `certificates update` subcommand - [ ] Add HTTP client tests (mocked) - [ ] Add CLI cmdtests for flag validation # Acceptance criteria - [ ] Certificate activation status can be toggled via CLI # Tests - Flag validation tests - HTTP client test for PATCH endpoint # Implementation notes - The only updatable field is `activated` (boolean) - Follow existing patterns in `internal/asc/client_signing.go` # References - `docs/openapi/paths.txt` - `docs/openapi/latest.json` - `internal/asc/client_signing.go`
kerem closed this issue 2026-02-26 21:33:34 +03:00
kerem commented 2026-02-26 21:33:34 +03:00
Author
Owner
Copy link

@rudrankriyam commented on GitHub (Feb 2, 2026):

@cursor please implement this issue. Add the UpdateCertificate client method and the CLI command to toggle the activated flag.

<!-- gh-comment-id:3837591508 --> @rudrankriyam commented on GitHub (Feb 2, 2026): @cursor please implement this issue. Add the UpdateCertificate client method and the CLI command to toggle the activated flag.
kerem commented 2026-02-26 21:33:34 +03:00
Author
Owner
Copy link

@cursor[bot] commented on GitHub (Feb 2, 2026):

Summary:

  • I added certificate activation update support end-to-end: new UpdateCertificate client method + request types (including activated in certificate attributes), plus a new asc certificates update --id ... --activated true|false CLI subcommand and help examples.
  • I added HTTP client coverage for the PATCH payload and CLI flag-validation coverage (cmdtest + package-level tests).

Tests:

  • make test
  • Recorded: go test ./internal/asc -run TestUpdateCertificate_SendsRequest and go test ./internal/cli/cmdtest -run TestCertificatesValidationErrors

Walkthrough artifact:

  • /opt/cursor/artifacts/certificates_update_tests/recording_demo.mp4 (terminal run of the two targeted tests above).
    Note: the mediaReview tool was unavailable, so I couldn’t auto-verify the recording; this is based on the computer-use run report.

View PR
Open in Cursor Open in Web

<!-- gh-comment-id:3837591715 --> @cursor[bot] commented on GitHub (Feb 2, 2026): Summary: - I added certificate activation update support end-to-end: new `UpdateCertificate` client method + request types (including `activated` in certificate attributes), plus a new `asc certificates update --id ... --activated true|false` CLI subcommand and help examples. - I added HTTP client coverage for the PATCH payload and CLI flag-validation coverage (cmdtest + package-level tests). Tests: - `make test` - Recorded: `go test ./internal/asc -run TestUpdateCertificate_SendsRequest` and `go test ./internal/cli/cmdtest -run TestCertificatesValidationErrors` Walkthrough artifact: - `/opt/cursor/artifacts/certificates_update_tests/recording_demo.mp4` (terminal run of the two targeted tests above). Note: the mediaReview tool was unavailable, so I couldn’t auto-verify the recording; this is based on the computer-use run report. <a href="https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/418"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/view-pr-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/view-pr-light.png"><img alt="View PR" width="86" height="28" src="https://cursor.com/assets/images/view-pr-light.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-8acf3543-86c9-4d60-8596-f002871d50eb"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-8acf3543-86c9-4d60-8596-f002871d50eb"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>
kerem commented 2026-02-26 21:33:34 +03:00
Author
Owner
Copy link

@rudrankriyam commented on GitHub (Feb 3, 2026):

Resolved in #418.

<!-- gh-comment-id:3840418183 --> @rudrankriyam commented on GitHub (Feb 3, 2026): Resolved in #418.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.1
1.1.0
1.0.1
1.0.0
0.49.1
0.49.0
0.48.1
0.48.0
0.47.1
0.47.0
0.46.2
0.46.1
0.46.0
0.45.4
0.45.3
0.45.2
0.45.1
0.45.0
0.44.2
0.44.1
0.44.0
0.43.0
0.42.0
0.41.4
0.41.3
0.41.2
0.41.1
0.41.0
0.40.1
0.40.0
0.39.1
0.39.0
0.38.3
0.38.2
0.38.1
0.38.0
0.37.3
0.37.2
0.37.1
0.37.0
0.36.3
0.36.2
0.36.1
0.36.0
0.35.3
0.35.2
0.35.1
0.35.0
0.34.1
0.34.0
0.33.2
0.33.1
0.33.0
0.32.0
0.31.3
0.31.2
0.31.1
0.31.0
0.30.0
0.29.3
0.29.2
0.29.1
0.29.0
0.28.14
0.28.13
0.28.12
0.28.11
0.28.10
0.28.9
0.28.8
0.28.7
0.28.6
0.28.5
0.28.4
0.28.3
0.28.2
0.28.1
0.28.0
0.27.0
0.26.4
0.26.3
0.26.2
0.26.1
0.26.0
0.25.4
0.25.3
0.25.1
0.25.0
0.24.3
0.24.2
0.24.1
0.24.0
0.23.5
0.23.4
0.23.3
0.23.2
0.23.1
0.23.0
0.22.1
0.22.0
0.21.0
0.20.2
0.20.1
0.20.0
0.19.3
0.19.2
0.19.1
0.19.0
0.18.2
0.18.1
0.18.0
0.17.0
0.16.0
0.15.0
0.14.0
0.13.0
0.12.4
0.12.3
0.12.2
0.12.1
0.12.0
0.11.0
0.10.2
0.10.1
0.10.0
0.9.0
0.8.1
0.8.0
0.7.0
0.6.0
0.5.0
0.3.1
0.3.0
0.2.0
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
Labels
Clear labels   
bug

   
bug

   
documentation

   
enhancement

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
bug
documentation
enhancement
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/App-Store-Connect-CLI#118
No description provided.