[PR #21] [MERGED] Fixes for issue #20 #142

New issue

Closed

opened 2026-02-26 21:32:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:32:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/seemoo-lab/AirGuard/pull/21
Author: @CampbellMG
Created: 12/23/2021
Status: ✅ Merged
Merged: 1/3/2022
Merged by: @Trup3s

Base: main ← Head: main

📝 Commits (2)

f0f460b (fix #20) Dismissed dialog rather closing activity when dismissing dialog
dad4615 (fix #20) Prevented showing duplicate dialogs

📊 Changes

1 file changed (+9 additions, -6 deletions)

View changed files

📝 app/src/main/java/de/seemoo/at_tracking_detection/ui/OnboardingActivity.kt (+9 -6)

📄 Description

Issue 1

This is fixed by dismissing the dialog rather than closing the activity entirely. I am assuming this is the intended flow, however, we can also dismiss the activity. We just need to ensure the fix for issue 2 is in place as I believe opening the second dialog after killing the activity is the root cause.

Issue 2

To fix duplicate dialogs I've just stored a reference to a dialog once it's opened. If the dialog is still showing we don't show another. This is necessary as onUserDeniedPermission seems to be called several times when dismissing a permission prompt.

Please let me know what you think.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/seemoo-lab/AirGuard/pull/21 **Author:** [@CampbellMG](https://github.com/CampbellMG) **Created:** 12/23/2021 **Status:** ✅ Merged **Merged:** 1/3/2022 **Merged by:** [@Trup3s](https://github.com/Trup3s) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`f0f460b`](https://github.com/seemoo-lab/AirGuard/commit/f0f460baf93ecda3eb61e3be6c55ce91f018d155) (fix #20) Dismissed dialog rather closing activity when dismissing dialog - [`dad4615`](https://github.com/seemoo-lab/AirGuard/commit/dad46150538c9406eb83d9ee6c802e53ad365e13) (fix #20) Prevented showing duplicate dialogs ### 📊 Changes **1 file changed** (+9 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/de/seemoo/at_tracking_detection/ui/OnboardingActivity.kt` (+9 -6) </details> ### 📄 Description # Issue 1 This is fixed by dismissing the dialog rather than closing the activity entirely. I am assuming this is the intended flow, however, we can also dismiss the activity. We just need to ensure the fix for issue 2 is in place as I believe opening the second dialog after killing the activity is the root cause. # Issue 2 To fix duplicate dialogs I've just stored a reference to a dialog once it's opened. If the dialog is still showing we don't show another. This is necessary as onUserDeniedPermission seems to be called several times when dismissing a permission prompt. Please let me know what you think. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>