[PR #999] [CLOSED] Fix resource quota issues by adding explicit UTF8 encoding to File.ReadAllText calls #933

New issue

Closed

opened 2026-02-26 12:00:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:00:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/1Remote/1Remote/pull/999
Author: @Copilot
Created: 10/11/2025
Status: ❌ Closed

Base: main ← Head: copilot/debug-issue-996

📝 Commits (2)

9064cf4 Initial plan
5f15cad Fix resource quota issues by adding explicit UTF8 encoding to File.ReadAllText calls

📊 Changes

9 files changed (+11 additions, -9 deletions)

View changed files

📝 Ui/Service/ConfigurationService.cs (+1 -1)
📝 Ui/Service/DataSource/DataSourceService.cs (+1 -1)
📝 Ui/Service/Locality/LocalityConnectRecorder.cs (+1 -1)
📝 Ui/Service/Locality/LocalityListViewService.cs (+1 -1)
📝 Ui/Service/Locality/LocalityService.cs (+1 -1)
📝 Ui/Service/Locality/LocalityTagService.cs (+1 -1)
📝 Ui/Service/Locality/LocalityTreeViewService.cs (+1 -1)
📝 Ui/Utils/PRemoteM/PRemoteMTransferHelper.cs (+2 -1)
📝 Ui/Utils/WindowsSdk/PasswordVaultManager/PasswordVaultManagerFileSystem.cs (+2 -1)

📄 Description

Summary

This PR addresses issue #996 where users encounter "Not enough quota is available to process this command" errors when opening a second RDP session, even with large pagefiles configured.

Problem

The application was experiencing Windows system resource quota exhaustion, particularly when:

Opening multiple RDP sessions
Loading multiple configuration files
Running on systems under resource pressure

The error message Nicht genügend Quoten verfügbar, um diesen Befehl zu verarbeiten (German: "Not enough quota available to process this command") indicated the application was consuming more system resources than expected.

Root Cause

Investigation revealed that 9 files throughout the codebase were calling File.ReadAllText() without specifying an encoding parameter:

// Before - causes encoding auto-detection overhead
var tmp = JsonConvert.DeserializeObject<dynamic>(File.ReadAllText(profileJsonPath));

// After - explicit UTF8 encoding
var tmp = JsonConvert.DeserializeObject<dynamic>(File.ReadAllText(profileJsonPath, Encoding.UTF8));

When encoding is not specified, the .NET runtime performs automatic encoding detection which:

Requires additional CPU cycles and memory allocations
Makes extra system calls to analyze file content
Consumes more file handles and resources
Creates cumulative overhead when many files are read during application startup/operation

Under resource pressure (especially when opening multiple RDP sessions), this additional overhead can contribute to exhausting Windows system quotas for handles, GDI objects, or memory.

Changes

Added explicit Encoding.UTF8 parameter to all File.ReadAllText() calls in the following files:

Ui/Utils/PRemoteM/PRemoteMTransferHelper.cs
Ui/Service/Locality/LocalityConnectRecorder.cs
Ui/Service/Locality/LocalityListViewService.cs
Ui/Service/Locality/LocalityService.cs
Ui/Service/Locality/LocalityTagService.cs
Ui/Service/Locality/LocalityTreeViewService.cs
Ui/Service/ConfigurationService.cs
Ui/Service/DataSource/DataSourceService.cs
Ui/Utils/WindowsSdk/PasswordVaultManager/PasswordVaultManagerFileSystem.cs

Benefits

Reduced Resource Consumption: Eliminates encoding detection overhead for all file read operations
Predictable Behavior: All configuration files now consistently use UTF8 encoding (JSON standard)
Better Performance: Slightly faster file operations by skipping auto-detection
Improved Reliability: Lower probability of hitting Windows resource quota limits
Minimal Impact: Only 11 lines changed across 9 files - no functional changes to application behavior

Testing

This change should be tested by:

Opening multiple RDP sessions sequentially
Verifying all configuration files load correctly
Monitoring system resource usage (handles, GDI objects, memory) under load
Testing on systems with limited resources or many simultaneous connections

Fixes #996

Original prompt

检查并找出引起 @1Remote/1Remote/issues/996 问题的原因。

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/1Remote/1Remote/pull/999 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 10/11/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `copilot/debug-issue-996` --- ### 📝 Commits (2) - [`9064cf4`](https://github.com/1Remote/1Remote/commit/9064cf4b0b79749b6a8b6cb15e0a394667ed8e9b) Initial plan - [`5f15cad`](https://github.com/1Remote/1Remote/commit/5f15cad939537d07f95426fdbc305951aca3404c) Fix resource quota issues by adding explicit UTF8 encoding to File.ReadAllText calls ### 📊 Changes **9 files changed** (+11 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `Ui/Service/ConfigurationService.cs` (+1 -1) 📝 `Ui/Service/DataSource/DataSourceService.cs` (+1 -1) 📝 `Ui/Service/Locality/LocalityConnectRecorder.cs` (+1 -1) 📝 `Ui/Service/Locality/LocalityListViewService.cs` (+1 -1) 📝 `Ui/Service/Locality/LocalityService.cs` (+1 -1) 📝 `Ui/Service/Locality/LocalityTagService.cs` (+1 -1) 📝 `Ui/Service/Locality/LocalityTreeViewService.cs` (+1 -1) 📝 `Ui/Utils/PRemoteM/PRemoteMTransferHelper.cs` (+2 -1) 📝 `Ui/Utils/WindowsSdk/PasswordVaultManager/PasswordVaultManagerFileSystem.cs` (+2 -1) </details> ### 📄 Description ## Summary This PR addresses issue #996 where users encounter "Not enough quota is available to process this command" errors when opening a second RDP session, even with large pagefiles configured. ## Problem The application was experiencing Windows system resource quota exhaustion, particularly when: - Opening multiple RDP sessions - Loading multiple configuration files - Running on systems under resource pressure The error message `Nicht genügend Quoten verfügbar, um diesen Befehl zu verarbeiten` (German: "Not enough quota available to process this command") indicated the application was consuming more system resources than expected. ## Root Cause Investigation revealed that 9 files throughout the codebase were calling `File.ReadAllText()` without specifying an encoding parameter: ```csharp // Before - causes encoding auto-detection overhead var tmp = JsonConvert.DeserializeObject<dynamic>(File.ReadAllText(profileJsonPath)); // After - explicit UTF8 encoding var tmp = JsonConvert.DeserializeObject<dynamic>(File.ReadAllText(profileJsonPath, Encoding.UTF8)); ``` When encoding is not specified, the .NET runtime performs automatic encoding detection which: 1. Requires additional CPU cycles and memory allocations 2. Makes extra system calls to analyze file content 3. Consumes more file handles and resources 4. Creates cumulative overhead when many files are read during application startup/operation Under resource pressure (especially when opening multiple RDP sessions), this additional overhead can contribute to exhausting Windows system quotas for handles, GDI objects, or memory. ## Changes Added explicit `Encoding.UTF8` parameter to all `File.ReadAllText()` calls in the following files: - `Ui/Utils/PRemoteM/PRemoteMTransferHelper.cs` - `Ui/Service/Locality/LocalityConnectRecorder.cs` - `Ui/Service/Locality/LocalityListViewService.cs` - `Ui/Service/Locality/LocalityService.cs` - `Ui/Service/Locality/LocalityTagService.cs` - `Ui/Service/Locality/LocalityTreeViewService.cs` - `Ui/Service/ConfigurationService.cs` - `Ui/Service/DataSource/DataSourceService.cs` - `Ui/Utils/WindowsSdk/PasswordVaultManager/PasswordVaultManagerFileSystem.cs` ## Benefits - **Reduced Resource Consumption**: Eliminates encoding detection overhead for all file read operations - **Predictable Behavior**: All configuration files now consistently use UTF8 encoding (JSON standard) - **Better Performance**: Slightly faster file operations by skipping auto-detection - **Improved Reliability**: Lower probability of hitting Windows resource quota limits - **Minimal Impact**: Only 11 lines changed across 9 files - no functional changes to application behavior ## Testing This change should be tested by: 1. Opening multiple RDP sessions sequentially 2. Verifying all configuration files load correctly 3. Monitoring system resource usage (handles, GDI objects, memory) under load 4. Testing on systems with limited resources or many simultaneous connections Fixes #996  <details> <summary>Original prompt</summary> > 检查并找出引起 @1Remote/1Remote/issues/996 问题的原因。 </details>  --- 💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click [here](https://survey3.medallia.com/?EAHeSx-AP01bZqG0Ld9QLQ) to start the survey. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>