[PR #852] [MERGED] Add option "Close button of the main window ends everything" (for #846) #905

New issue

Closed

opened 2026-02-26 12:00:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:00:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/1Remote/1Remote/pull/852
Author: @itagagaki
Created: 2/6/2025
Status: ✅ Merged
Merged: 2/9/2025
Merged by: @VShawn

Base: main ← Head: add-option-exit-by-close

📝 Commits (2)

54b9068 Add option "Close button of the main window ends everything"
bdd4b48 Use combo box instead of checkbox for close button behavior

📊 Changes

17 files changed (+72 additions, -14 deletions)

View changed files

📝 Ui/Resources/Languages/cs-cz.xaml (+2 -1)
📝 Ui/Resources/Languages/de-de.xaml (+2 -1)
📝 Ui/Resources/Languages/en-us.xaml (+2 -1)
📝 Ui/Resources/Languages/fr-fr.xaml (+2 -1)
📝 Ui/Resources/Languages/gl-es.xaml (+2 -1)
📝 Ui/Resources/Languages/glossary.csv (+3 -1)
📝 Ui/Resources/Languages/glossary_translated_by_google.csv (+2 -1)
📝 Ui/Resources/Languages/ja-jp.xaml (+2 -1)
📝 Ui/Resources/Languages/pl-pl.xaml (+2 -1)
📝 Ui/Resources/Languages/pt-br.xaml (+2 -1)
📝 Ui/Resources/Languages/ru-ru.xaml (+2 -1)
📝 Ui/Resources/Languages/zh-cn.xaml (+2 -1)
📝 Ui/Resources/Languages/zh-tw.xaml (+2 -1)
📝 Ui/Service/ConfigurationService.cs (+6 -0)
📝 Ui/View/MainWindowView.xaml.cs (+11 -0)
📝 Ui/View/Settings/General/GeneralSettingView.xaml (+16 -1)
📝 Ui/View/Settings/General/GeneralSettingViewModel.cs (+12 -0)

📄 Description

Realized the #846 request. In my opinion this option would be nice to have.

You can see the diffs in the language resources other than the ones I added. I don't know why that is.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/1Remote/1Remote/pull/852 **Author:** [@itagagaki](https://github.com/itagagaki) **Created:** 2/6/2025 **Status:** ✅ Merged **Merged:** 2/9/2025 **Merged by:** [@VShawn](https://github.com/VShawn) **Base:** `main` ← **Head:** `add-option-exit-by-close` --- ### 📝 Commits (2) - [`54b9068`](https://github.com/1Remote/1Remote/commit/54b906878dacff4d21ebb94b2a62686a98ee6d18) Add option "Close button of the main window ends everything" - [`bdd4b48`](https://github.com/1Remote/1Remote/commit/bdd4b4808ace4620089b6d117da2efc791407927) Use combo box instead of checkbox for close button behavior ### 📊 Changes **17 files changed** (+72 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `Ui/Resources/Languages/cs-cz.xaml` (+2 -1) 📝 `Ui/Resources/Languages/de-de.xaml` (+2 -1) 📝 `Ui/Resources/Languages/en-us.xaml` (+2 -1) 📝 `Ui/Resources/Languages/fr-fr.xaml` (+2 -1) 📝 `Ui/Resources/Languages/gl-es.xaml` (+2 -1) 📝 `Ui/Resources/Languages/glossary.csv` (+3 -1) 📝 `Ui/Resources/Languages/glossary_translated_by_google.csv` (+2 -1) 📝 `Ui/Resources/Languages/ja-jp.xaml` (+2 -1) 📝 `Ui/Resources/Languages/pl-pl.xaml` (+2 -1) 📝 `Ui/Resources/Languages/pt-br.xaml` (+2 -1) 📝 `Ui/Resources/Languages/ru-ru.xaml` (+2 -1) 📝 `Ui/Resources/Languages/zh-cn.xaml` (+2 -1) 📝 `Ui/Resources/Languages/zh-tw.xaml` (+2 -1) 📝 `Ui/Service/ConfigurationService.cs` (+6 -0) 📝 `Ui/View/MainWindowView.xaml.cs` (+11 -0) 📝 `Ui/View/Settings/General/GeneralSettingView.xaml` (+16 -1) 📝 `Ui/View/Settings/General/GeneralSettingViewModel.cs` (+12 -0) </details> ### 📄 Description Realized the #846 request. In my opinion this option would be nice to have. You can see the diffs in the language resources other than the ones I added. I don't know why that is. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 12:00:23 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/1Remote#905

No description provided.

Rows
Columns