mirror of
https://github.com/1Remote/1Remote.git
synced 2026-04-25 13:36:03 +03:00
[GH-ISSUE #777] Configuration option to open log may open Explorer in the background and has latency #635
Labels
No labels
area-configuration
area-ct-app
area-ct-rdp
area-ct-remoteapp
area-ct-ssh
area-ct-vnc
area-launcher
area-list
area-tags
area-teamwork
bug
chore
dependencies
general-build/ci
general-performance
general-refactor
general-security
general-supportive
general-ux
meta-documentation
meta-enhancement
meta-enhancement
meta-feature
meta-help-wanted
meta-unknown-error
priority-hi
priority-low
pull-request
question
resolution-duplicate
resolution-invalid
resolution-wontfix
stale
task-put-off
task-still-considering
task-working-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/1Remote#635
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @itagagaki on GitHub (Nov 19, 2024).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/777
Originally assigned to: @VShawn on GitHub.
Options > General > [Log file] is not editable.
And the loupe button to the right of it doesn't seem to work.
@VShawn commented on GitHub (Nov 19, 2024):
Yes log input box was designed to be non-editable.
The button on the right is to open the directory where the log files are located via explorer.exe.
@itagagaki commented on GitHub (Nov 19, 2024):
Okay, but if the path is long, I can only see from the beginning to the middle. So I can't know the location or the filename.
And no window opens when I click the button.
@VShawn commented on GitHub (Nov 20, 2024):
https://github.com/user-attachments/assets/a41a308e-5035-40fc-ae14-32915b1b2c6f
though the path is long, you can drag text to see all characters.
the button works fine on my end, so I have no clue what's going on.
@itagagaki commented on GitHub (Nov 20, 2024):
I just tried the same thing and was able to do it. This is strange because I couldn't do either yesterday. I'll close it for now and report back if I find anything new.
@itagagaki commented on GitHub (Dec 1, 2024):
Reproduced, so I reopen this.
Just now, the file selection dialog did not appear.
Sometimes it appears after restarting the application, and sometimes it still does not appear.
Even when a dialog does appear, the fact that it takes a second or so to appear after clicking the button is also a bit concerning.
I don't know what the cause is, but is it possible that it is displayed at coordinates outside the desktop? I use multiple monitors, could that have something to do with this?
@VShawn commented on GitHub (Dec 4, 2024):
I don't know the cause either.
But the code to launch explorer.exe to open the log file is as follows. I think such simple code shouldn't have any issues.
github.com/VShawn/Shawn.Utils@de85b238a8/Shawn.Utils.Wpf/FileSystem/SelectFileHelper.cs (L154-L162)I initially suspected it was a bug with Windows 11, as I've encountered bugs since Win11 refacted their explorer. However, I tested it on version 23H2 22631.4317, and open the log works fine.
@itagagaki commented on GitHub (Dec 4, 2024):
Hmmm... OK, I'll try to find a way to investigate.
@itagagaki commented on GitHub (Dec 5, 2024):
I have not reproduced this since, but we have noticed that when Explorer is launched, it is often completely hidden behind other windows. I would like it to appear in front of every window, but this may be unavoidable due to Windows specifications.
I have done some research and found that this might also be related to the
ForegroundLockTimeoutvalue in the registry.If I come across a phenomenon other than hiding behind other windows, I will use this tool to investigate.
GUIPropView - View and set Windows properties from command line or GUI
@majkinetor commented on GitHub (Dec 5, 2024):
Such a trivial thing as starting explorer in given path should not cause concern. I can't reproduce the problem.
This can be brute forced pretty easily (start explorer, get its hwnd, activate it). It seems something is stealing focus on your OS.
@itagagaki commented on GitHub (Dec 5, 2024):
Other file selection dialogs invoked by 1Remote are fine. The reason why only this dialog (open the log file location) doesn't explained by your speculation.
@VShawn commented on GitHub (Dec 5, 2024):
file selection dialogsandopen the log file locationare two different things. while thefile selection dialogscalls system APIs, andopen the log file locationby launches a process. It seems that there was an issue with the process launch on your end.Although we don't know why, I provide a text box displaying the complete path of the log, so that in the case the explorer fails to launch, users can simply copy the path and manually open the log.
@itagagaki commented on GitHub (Dec 5, 2024):
In my environment (Windows 10 Pro 22H2 64bit), explorer.exe did not appear at the top when launched with
/selectoption.How does it work on yours?
https://github.com/user-attachments/assets/f99a92b6-cbe4-4124-9926-8c5d4b9b76ad
@majkinetor commented on GitHub (Dec 5, 2024):
selector not, its the same here. Windows 11 and 10 here.Like I said, this is a local problem, this situation of yours is atypical.
Besides, even if you can't fix it, is it really that important? In any case, if its about select, lets just remove it.
@itagagaki commented on GitHub (Dec 5, 2024):
Is it important or not?
Reported and continue to investigate because I saw a problem on my end, because I have no evidence yet that this is a local problem.
That's all I do.
@VShawn commented on GitHub (Dec 5, 2024):
https://github.com/user-attachments/assets/371aae41-789e-4275-a0d3-11efac4d0594
just sharing how it works on my end
@VShawn commented on GitHub (Dec 5, 2024):
Any error feedback is encouraged, regardless of whether the bug is important or not. we investigate - if we can fix it, we'll repair it; if we can't find the cause, we suspend and work around it.
@itagagaki commented on GitHub (Dec 5, 2024):
One thing I noticed as a result of my investigation.
The problem only occurs when the Explorer ribbon is expanded. This is exactly the same on my other PC (which has the same version of Windows).
However, VShawn does not have the problem with the expanded ribbon, so I still don't know what the root cause is.
https://github.com/user-attachments/assets/ba881c99-a198-4399-9390-62b65727409c
@majkinetor commented on GitHub (Dec 5, 2024):
You should manage time my friend :) This doesnt deserve it
@itagagaki commented on GitHub (Dec 5, 2024):
Why should you complain to me?
If you don't want to do anything about it, well, you don't have to. And stay out of it.
Don't tell me what to do.
@majkinetor commented on GitHub (Dec 5, 2024):
... we are a bit touchy...
and rude. Maybe its AI though.
@majkinetor commented on GitHub (Dec 5, 2024):
Closing this as local problem.
@itagagaki commented on GitHub (Dec 5, 2024):
Hey, which is rude?
@majkinetor commented on GitHub (Dec 5, 2024):
OK, ignore that. Lost in translation for sure or substandard translation AI/app.
@itagagaki commented on GitHub (Dec 5, 2024):
No, it is not. I asked who is rude, me or you?
@itagagaki commented on GitHub (Dec 5, 2024):
No evidence
@majkinetor commented on GitHub (Dec 5, 2024):
I don't want irrelevant spam here, dominating discussions (few are OK). If there is anything more you want to know, contact me via email.
Your N=1 evidence is lower then our N>1 evidence.
@itagagaki commented on GitHub (Dec 5, 2024):
Incorrect. N=2 on my end now.
@itagagaki commented on GitHub (Dec 5, 2024):
It is premature to assume without evidence that unexplained events are due to very limited and special circumstances.
I don't know why you feel compelled to behave this way.
@VShawn commented on GitHub (Dec 6, 2024):
I stand by @itagagaki on this one. Although I believe this bug is indeed not critical, the contributors who spent time helping investigate and test should be couraged not be discouraged.
BTW teting on my another win11
https://github.com/user-attachments/assets/759c05fd-a05c-499b-b0c3-2326ba52e9b6
@itagagaki commented on GitHub (Dec 11, 2024):
This is not a local issue.
For some time now (a few years?), Windows 10 has been experiencing a phenomenon where new windows are hidden behind other windows. The conditions under which this happens are unclear, ranging from noticeable to not so noticeable, etc. Often, even important UAC dialogs are hidden behind them and the user is unaware of it. I suspect that there is a bug in Windows that is not easy to fix because of its inconvenient specifications; as for Windows 11, I don't know because I haven't used it yet.
This issue is probably also due to this Windows bug. It's probably impossible to work around on the application side, and I don't think there should be any funny little tricks, so this issue should be closed as is.
@VShawn commented on GitHub (Dec 12, 2024):
Uh-huh?