starred/1Remote

Fork 0

mirror of https://github.com/1Remote/1Remote.git synced 2026-04-25 13:36:03 +03:00

[GH-ISSUE #807] FTP/SFTP: When an item is selected, it scrolls to the previous selection #3574

New issue

Closed

opened 2026-03-13 12:04:02 +03:00 by kerem · 4 comments

kerem commented

2026-03-13 12:04:02 +03:00

Owner

Originally created by @itagagaki on GitHub (Dec 12, 2024).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/807

Originally assigned to: @VShawn on GitHub.

To Reproduce

Select an item in FTP/SFTP server
Scroll until the item is outside the window
Reselect another item at that location

Actual behavior
It scrolls to the previous selection of step 1
The item is not in the selected state. (ok)
If you manually scroll to the newly selected item, you can see that it is actually selected. (ok)

Expected behavior
Do not scroll

Originally created by @itagagaki on GitHub (Dec 12, 2024). Original GitHub issue: https://github.com/1Remote/1Remote/issues/807 Originally assigned to: @VShawn on GitHub. **To Reproduce** 1. Select an item in FTP/SFTP server 2. Scroll until the item is outside the window 3. Reselect another item at that location **Actual behavior** It scrolls to the previous selection of step 1 The item is not in the selected state. (ok) If you manually scroll to the newly selected item, you can see that it is actually selected. (ok) **Expected behavior** Do not scroll

kerem

2026-03-13 12:04:02 +03:00

closed this issue
added the
bug
label

kerem commented

2026-03-13 12:04:18 +03:00

Author

Owner

@itagagaki commented on GitHub (Dec 12, 2024):

In FileTransmitHost constructor

            _vmRemote.PropertyChanged += (sender, args) =>
            {
                if (args.PropertyName == nameof(VmFileTransmitHost.SelectedRemoteItem))
                {
                    TvFileList.ScrollIntoView(TvFileList.SelectedItem);
                }
            };

If you select a new item, it will go in here, but TvFileList.SelectedItem will still be the previous item.
I need to learn how VmFileTransmitHost.SelectedRemoteItem and TvFileList.SelectedItem work. But it might be faster for you to fix it.

@itagagaki commented on GitHub (Dec 12, 2024): In FileTransmitHost constructor ``` _vmRemote.PropertyChanged += (sender, args) => { if (args.PropertyName == nameof(VmFileTransmitHost.SelectedRemoteItem)) { TvFileList.ScrollIntoView(TvFileList.SelectedItem); } }; ``` If you select a new item, it will go in here, but `TvFileList.SelectedItem` will still be the previous item. I need to learn how `VmFileTransmitHost.SelectedRemoteItem` and `TvFileList.SelectedItem` work. But it might be faster for you to fix it.

kerem commented

2026-03-13 12:04:23 +03:00

Author

Owner

@VShawn commented on GitHub (Dec 12, 2024):

I will fix it. better to have a screen recording

@VShawn commented on GitHub (Dec 12, 2024): I will fix it. better to have a screen recording

kerem commented

2026-03-13 12:04:28 +03:00

Author

Owner

@itagagaki commented on GitHub (Dec 12, 2024):

https://github.com/user-attachments/assets/107beb21-91b6-4135-ac09-f0efd3b16dfe

@itagagaki commented on GitHub (Dec 12, 2024): https://github.com/user-attachments/assets/107beb21-91b6-4135-ac09-f0efd3b16dfe

kerem commented

2026-03-13 12:04:33 +03:00

Author

Owner

@VShawn commented on GitHub (Dec 13, 2024):

i have fixed the ticket

@VShawn commented on GitHub (Dec 13, 2024): i have fixed the ticket

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/1Remote#3574

No description provided.

Rows
Columns