mirror of
https://github.com/1Remote/1Remote.git
synced 2026-04-25 05:26:04 +03:00
[GH-ISSUE #420] Non-intrusive availability detection #3238
Labels
No labels
area-configuration
area-ct-app
area-ct-rdp
area-ct-remoteapp
area-ct-ssh
area-ct-vnc
area-launcher
area-list
area-tags
area-teamwork
bug
chore
dependencies
general-build/ci
general-performance
general-refactor
general-security
general-supportive
general-ux
meta-documentation
meta-enhancement
meta-enhancement
meta-feature
meta-help-wanted
meta-unknown-error
priority-hi
priority-low
pull-request
question
resolution-duplicate
resolution-invalid
resolution-wontfix
stale
task-put-off
task-still-considering
task-working-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/1Remote#3238
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @majkinetor on GitHub (May 17, 2023).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/420
Originally assigned to: @VShawn on GitHub.
Availability detection occupies center part of the screen, is on top, and there is no way to minimize it or terminate it once started. When troubleshooting server disconnection this leads to bad user experience that I just witnessed. Also there is popup at the end that you must OK.
Possible solutions:
details
Use this instead:
In single run mode this window should autoclose if test is OK (same as now) and stay open on error. In bulk mode it should not close automatically.
This will go nicely with bulk testing we are plannning to do.
@VShawn commented on GitHub (May 18, 2023):
You found the place where I was being lazy during development :)
The point is, I don't want this popup to show in the taskbar, so the only way to remind people is to keep this window always on top. Otherwise, it might fall into background and no one would notice it.
Putting the window in the center is the easiest option because it avoids position calculation issues with multiple displays. Perhaps adding the ability to drag the window (yes, I was being lazy here too LOL) could solve the problem
@majkinetor commented on GitHub (May 18, 2023):
I always do 😄 , somehow I detect bugs in few seconds always.
Just keep a small toaster next to a tray, I think that would be OK even with on top window. Here is more detailed mockup:
We will have option pending depending on number of testing threads (but we could go with 5-10 by default). This is example of bulk test, single connection test works the same just 1 connection and auto closes if OK (or better, it doesn't show at all if ok, but shows on err).
It should be on good spot to start with, user shouldn't generally mess with it. Tray is perfect option for that IMO and it should be small anyway, currently its too big
@VShawn commented on GitHub (Jun 2, 2023):
is this ok?
@VShawn commented on GitHub (Jun 2, 2023):
is this ok?
@majkinetor commented on GitHub (Jun 2, 2023):
Some comments
For example in title -
Availability test ok: 1 err: 2@VShawn commented on GitHub (Jun 2, 2023):
it is none use here, this view is for available test before connection start, once any connect success, I will kill other ping tasks and close this pop and start connection, so user will not see any err connection.
This design make sense when address manual selectior is implemented.
I will take other comments, It may takes about my two days free time to achieve all UI effects:)
@majkinetor commented on GitHub (Jun 2, 2023):
You should never close this window if there is any error, in any case.
But user can still run tag or use multi connect in which case behavior should be the same - close it if all is good, leave it open otherwise.
@majkinetor commented on GitHub (Jun 6, 2023):
Comments on latest beta:
Its certainly better then before. The problem is, you introduce special cases (single vs multiple connections) , and good intreface avoids that.
details
@VShawn commented on GitHub (Jun 7, 2023):
This window is a address switcher, and the task is to test the connection speed of each address of 1 SERVER, return the fastest one. If the connection fails, notify the server that there is no available address. It's not for showing the status of several servers.
↓ find the fastest address from here
