mirror of
https://github.com/1Remote/1Remote.git
synced 2026-04-25 13:36:03 +03:00
[GH-ISSUE #43] Message prompt layer for RDP: Prevent annoying RDP popup #32
Labels
No labels
area-configuration
area-ct-app
area-ct-rdp
area-ct-remoteapp
area-ct-ssh
area-ct-vnc
area-launcher
area-list
area-tags
area-teamwork
bug
chore
dependencies
general-build/ci
general-performance
general-refactor
general-security
general-supportive
general-ux
meta-documentation
meta-enhancement
meta-enhancement
meta-feature
meta-help-wanted
meta-unknown-error
priority-hi
priority-low
pull-request
question
resolution-duplicate
resolution-invalid
resolution-wontfix
stale
task-put-off
task-still-considering
task-working-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/1Remote#32
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @majkinetor on GitHub (Dec 24, 2020).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/43
Originally assigned to: @VShawn on GitHub.
After RDP is retried 5 times popup appears very intrusively.
mRemoteNg prevents this somehow and it can continuously repeat until connection is established.
@VShawn commented on GitHub (Dec 25, 2020):
i dont think it's a good idea to keep reconnect with out a notification when connection error occurred,
maybe pop error message after several times auto reconnect failed would be better.
BTW, In my refactoring plan, the error message will no longer use the message box to pop up, but will be masked on the RDP display area by a special message prompt layer. when an error occurs, message prompt layer show and you can click a button on it to try to reconnect or close the form.
@majkinetor commented on GitHub (Dec 25, 2020):
This could be setup in connection settings, how would you like things handled.
Thats the way to do it, popups are antipattern in general.
@majkinetor commented on GitHub (Dec 26, 2020):
It gets even more annoying - if you have N tabs open on VPN, once you disconnect after few minutes you will get N pop-ups at the same time :)
@VShawn commented on GitHub (Jan 6, 2021):
I change message shown style like above, don't know if it work with your VPN case. could you help to test it?
Release.zip
@majkinetor commented on GitHub (Jan 6, 2021):
sure