[PR #1028] [MERGED] Fix TabWindowView disappearing from Windows taskbar after hide/show cycle #2862

New issue

Closed

opened 2026-03-01 17:23:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 17:23:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/1Remote/1Remote/pull/1028
Author: @Copilot
Created: 11/17/2025
Status: ✅ Merged
Merged: 11/20/2025
Merged by: @VShawn

Base: main ← Head: copilot/fix-tabview-taskbar-issue

📝 Commits (2)

6e580c3 Initial plan
f0763c9 Fix: Explicitly set ShowInTaskbar=true for TabWindowView to prevent taskbar hiding

📊 Changes

3 files changed (+3 additions, -0 deletions)

View changed files

📝 Ui/Service/SessionControlService.cs (+1 -0)
📝 Ui/Service/SessionControlService_OpenConnection.cs (+1 -0)
📝 Ui/Service/SessionControlService_WindowControl.cs (+1 -0)

📄 Description

Tab windows were being removed from the Windows taskbar after closing all tabs and reopening connections. WPF doesn't automatically restore ShowInTaskbar after Hide()/Show() cycles.

Changes

Added explicit ShowInTaskbar = true after Show() calls in three locations:

SessionControlService.cs - When reactivating existing tab windows
SessionControlService_WindowControl.cs - When creating new tab windows
SessionControlService_OpenConnection.cs - When opening connections

// Before
tab.Show();
tab.Activate();

// After
tab.Show();
tab.ShowInTaskbar = true;
tab.Activate();

This matches the existing pattern in MainWindowView.ShowMe().

Original prompt

issue #1026 描述了 tab 窗体在使用一段时间后从 Windows 任务栏中被隐藏。检查代码中是否对 tabview 的任务栏图标进行了操作，或者找寻其他可能的原因。总之先分析代码和逻辑，再尝试修复。

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/1Remote/1Remote/pull/1028 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 11/17/2025 **Status:** ✅ Merged **Merged:** 11/20/2025 **Merged by:** [@VShawn](https://github.com/VShawn) **Base:** `main` ← **Head:** `copilot/fix-tabview-taskbar-issue` --- ### 📝 Commits (2) - [`6e580c3`](https://github.com/1Remote/1Remote/commit/6e580c3003edd6e73363c1b043af68a3e85e282f) Initial plan - [`f0763c9`](https://github.com/1Remote/1Remote/commit/f0763c9181e50eab9a651a85d76d8feb1fb3db1a) Fix: Explicitly set ShowInTaskbar=true for TabWindowView to prevent taskbar hiding ### 📊 Changes **3 files changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Ui/Service/SessionControlService.cs` (+1 -0) 📝 `Ui/Service/SessionControlService_OpenConnection.cs` (+1 -0) 📝 `Ui/Service/SessionControlService_WindowControl.cs` (+1 -0) </details> ### 📄 Description Tab windows were being removed from the Windows taskbar after closing all tabs and reopening connections. WPF doesn't automatically restore `ShowInTaskbar` after `Hide()`/`Show()` cycles. ## Changes Added explicit `ShowInTaskbar = true` after `Show()` calls in three locations: - **SessionControlService.cs** - When reactivating existing tab windows - **SessionControlService_WindowControl.cs** - When creating new tab windows - **SessionControlService_OpenConnection.cs** - When opening connections ```csharp // Before tab.Show(); tab.Activate(); // After tab.Show(); tab.ShowInTaskbar = true; tab.Activate(); ``` This matches the existing pattern in `MainWindowView.ShowMe()`.  <details> <summary>Original prompt</summary> > issue #1026 描述了 tab 窗体在使用一段时间后从 Windows 任务栏中被隐藏。检查代码中是否对 tabview 的任务栏图标进行了操作，或者找寻其他可能的原因。总之先分析代码和逻辑，再尝试修复。 </details>  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/1Remote/1Remote/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 17:23:33 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/1Remote#2862

No description provided.

Rows
Columns