[PR #836] [MERGED] Fix (S)FTP processing (Fix #828) #2823

Closed
opened 2026-03-01 17:23:25 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/1Remote/1Remote/pull/836
Author: @itagagaki
Created: 1/20/2025
Status: Merged
Merged: 1/24/2025
Merged by: @VShawn

Base: mainHead: fix-ftp-processing


📝 Commits (1)

📊 Changes

5 files changed (+395 additions, -486 deletions)

View changed files

📝 Ui/Model/Protocol/FileTransmit/Transmitters/ITransmitter.cs (+11 -10)
📝 Ui/Model/Protocol/FileTransmit/Transmitters/TransmissionController/TransmitTask.cs (+47 -51)
📝 Ui/Model/Protocol/FileTransmit/Transmitters/TransmitterFtp.cs (+122 -163)
📝 Ui/Model/Protocol/FileTransmit/Transmitters/TransmitterSFtp.cs (+132 -180)
📝 Ui/View/Host/ProtocolHosts/VmFileTransmitHost.cs (+83 -82)

📄 Description

  • Redesign asynchronous processing for (S)FTP
  • Remove ingenuity in keep-alive for FTP and use Config.Noop = true instead
  • Fix file transfer progress deviation

This fixes #828


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/1Remote/1Remote/pull/836 **Author:** [@itagagaki](https://github.com/itagagaki) **Created:** 1/20/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@VShawn](https://github.com/VShawn) **Base:** `main` ← **Head:** `fix-ftp-processing` --- ### 📝 Commits (1) - [`d1011fd`](https://github.com/1Remote/1Remote/commit/d1011fd310160c5703eb8ff6b79d4c251e2b4016) Fix (S)FTP processing ### 📊 Changes **5 files changed** (+395 additions, -486 deletions) <details> <summary>View changed files</summary> 📝 `Ui/Model/Protocol/FileTransmit/Transmitters/ITransmitter.cs` (+11 -10) 📝 `Ui/Model/Protocol/FileTransmit/Transmitters/TransmissionController/TransmitTask.cs` (+47 -51) 📝 `Ui/Model/Protocol/FileTransmit/Transmitters/TransmitterFtp.cs` (+122 -163) 📝 `Ui/Model/Protocol/FileTransmit/Transmitters/TransmitterSFtp.cs` (+132 -180) 📝 `Ui/View/Host/ProtocolHosts/VmFileTransmitHost.cs` (+83 -82) </details> ### 📄 Description - Redesign asynchronous processing for (S)FTP - Remove ingenuity in keep-alive for FTP and use Config.Noop = true instead - Fix file transfer progress deviation This fixes #828 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 17:23:25 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/1Remote#2823
No description provided.