[GH-ISSUE #302] Follow system theme #264

Closed
opened 2026-02-26 11:57:29 +03:00 by kerem · 4 comments
Owner

Originally created by @majkinetor on GitHub (Oct 13, 2022).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/302

Originally assigned to: @VShawn on GitHub.

Is your enhancement related to a problem? Please describe.
We have an option to choose theme. Among them are dark and light themes.

Describe the solution you'd like
There should be an checkbox in theme configuration to follow system theme. If choosen, app automatically determines if its going to use light or dark theme based on OS settings.

Originally created by @majkinetor on GitHub (Oct 13, 2022). Original GitHub issue: https://github.com/1Remote/1Remote/issues/302 Originally assigned to: @VShawn on GitHub. **Is your enhancement related to a problem? Please describe.** We have an option to choose theme. Among them are dark and light themes. **Describe the solution you'd like** There should be an checkbox in theme configuration to follow system theme. If choosen, app automatically determines if its going to use light or dark theme based on OS settings.
Author
Owner

@VShawn commented on GitHub (Oct 13, 2022):

not sure how to tigger by system theme changed event in a win32 app.

More investigation is needed.

<!-- gh-comment-id:1277262294 --> @VShawn commented on GitHub (Oct 13, 2022): not sure how to tigger by system theme changed event in a win32 app. More investigation is needed.
Author
Owner

@majkinetor commented on GitHub (Oct 13, 2022):

Its a registry key. See this module.

Since PRM is mostly run constantly, it needs to check this on activation and switch theme. Its usuall that apps do this on the startup, but in this case it would be meaningless.

<!-- gh-comment-id:1277269288 --> @majkinetor commented on GitHub (Oct 13, 2022): Its a registry key. See [this module](https://github.com/leandrocrs/windows-theme). Since PRM is mostly run constantly, it needs to check this on activation and switch theme. Its usuall that apps do this on the startup, but in this case it would be meaningless.
Author
Owner
<!-- gh-comment-id:1363183895 --> @majkinetor commented on GitHub (Dec 22, 2022): FYI https://learn.microsoft.com/en-us/windows/apps/desktop/modernize/apply-windows-themes
Author
Owner

@VShawn commented on GitHub (Jun 21, 2023):

I now believe that we should not spend time on this ticket as it does not provide core functionality and cannot enhance UX significantly

<!-- gh-comment-id:1600309309 --> @VShawn commented on GitHub (Jun 21, 2023): I now believe that we should not spend time on this ticket as it does not provide core functionality and cannot enhance UX significantly
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/1Remote#264
No description provided.