mirror of
https://github.com/1Remote/1Remote.git
synced 2026-04-25 13:36:03 +03:00
[GH-ISSUE #302] Follow system theme #264
Labels
No labels
area-configuration
area-ct-app
area-ct-rdp
area-ct-remoteapp
area-ct-ssh
area-ct-vnc
area-launcher
area-list
area-tags
area-teamwork
bug
chore
dependencies
general-build/ci
general-performance
general-refactor
general-security
general-supportive
general-ux
meta-documentation
meta-enhancement
meta-enhancement
meta-feature
meta-help-wanted
meta-unknown-error
priority-hi
priority-low
pull-request
question
resolution-duplicate
resolution-invalid
resolution-wontfix
stale
task-put-off
task-still-considering
task-working-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/1Remote#264
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @majkinetor on GitHub (Oct 13, 2022).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/302
Originally assigned to: @VShawn on GitHub.
Is your enhancement related to a problem? Please describe.
We have an option to choose theme. Among them are dark and light themes.
Describe the solution you'd like
There should be an checkbox in theme configuration to follow system theme. If choosen, app automatically determines if its going to use light or dark theme based on OS settings.
@VShawn commented on GitHub (Oct 13, 2022):
not sure how to tigger by system theme changed event in a win32 app.
More investigation is needed.
@majkinetor commented on GitHub (Oct 13, 2022):
Its a registry key. See this module.
Since PRM is mostly run constantly, it needs to check this on activation and switch theme. Its usuall that apps do this on the startup, but in this case it would be meaningless.
@majkinetor commented on GitHub (Dec 22, 2022):
FYI
https://learn.microsoft.com/en-us/windows/apps/desktop/modernize/apply-windows-themes
@VShawn commented on GitHub (Jun 21, 2023):
I now believe that we should not spend time on this ticket as it does not provide core functionality and cannot enhance UX significantly